Validate referral invite emails before throttling#144
Open
absalonCRC wants to merge 1 commit into
Open
Conversation
Author
|
Maintainer note for the active uGig affiliate/referral testing bounty ( Clean PRs submitted for this bounty:
Payment address for the bounty: SOL Happy to adjust any of these if you prefer a different validation/error-handling style. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The referral invite API applied hourly/daily invite limits before proving that any submitted email was usable. A batch of invalid email strings could return
429 Too many invitesinstead of a 400 validation error.Validation
pnpm test:run src/app/api/referrals/route.test.tspnpm exec eslint src/app/api/referrals/route.ts src/app/api/referrals/route.test.tspnpm type-checkgit diff --checkPayment for the active uGig affiliate testing bounty can go to SOL:
27sdMYXofqoM9qR13bZhccRNYeEgYn5EoHXTSJn4QWKP.Payment fallback: PayPal cultofrozen@gmail.com