fix: make build script work on Windows#278
Conversation
Greptile SummaryThis PR fixes the
Confidence Score: 5/5Safe to merge — the change is a straightforward cross-platform fix with correct exit-code propagation and no functional regressions on POSIX. The wrapper script is simple, correctly inherits the full environment, and properly forwards the child process exit code. The only nuance is that appending --max-old-space-size=1024 after an existing NODE_OPTIONS that already contains the flag could silently cap a higher custom limit, but this is an edge case unlikely to affect normal CI or developer workflows. scripts/build-next.js — the NODE_OPTIONS merging logic could override a caller-supplied higher heap limit. Important Files Changed
Reviews (2): Last reviewed commit: "fix: make build script work on Windows" | Re-trigger Greptile |
fbbb398 to
3ca1625
Compare
Summary
NODE_OPTIONS=...assignmentNODE_OPTIONSbefore runningnext buildFixes #277
Payment
Test plan
cmd /c npm run buildbefore the change fails immediately with'NODE_OPTIONS' is not recognized as an internal or external command, operable program or batch file.cmd /c npm run buildafter the change reaches thenext buildlaunch path; in this fresh checkout it then stops because dependencies are not installed (nextis missing)node --check scripts/build-next.js