make MsgPackContext thread-safe #89
Conversation
aensidhe
left a comment
There was a problem hiding this comment.
So, it was a deliberate decision not to use ConcurrentDictionary here to reduce memory footprint. But yeah, ok, looks legit for now. CI looks broken, will need to look into it.
I'll be able to do it in late August for sure. Can't promise anything before that.
|
@pavlua please update this PR and let's merge it. |
7074ab7 to
81fe6ac
Compare
|
@aensidhe It turns out there is a problem with CI: secrets are not passed to the runner when a workflow is triggered from a forked repository (https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflows-in-forked-repositories). This means that dotnet nuget push step fails, since it uses nuget API key. Possible workaround is to use 'pull_request_target' event instead of 'pull_request' in ci.yml, I'll try to investigate |
81fe6ac to
42c0c78
Compare
42c0c78 to
fe655e6
Compare
fix for #77