Prevent intervals from exploding#9
Merged
programmerjake merged 2 commits intoprogrammerjake:masterfrom Aug 21, 2025
Merged
Conversation
Owner
|
please add some tests that check that the intervals don't explode. Changing how |
55f25ee to
6264b8e
Compare
6264b8e to
de1068d
Compare
Contributor
Author
|
Makes sense, I added some testcases |
programmerjake
approved these changes
Aug 17, 2025
|
|
||
| for _ in 0..100 { | ||
| num = num.pow((1, 2)); | ||
| num = num.pow((2, 1)); |
Owner
There was a problem hiding this comment.
you can just use num = num.pow(2);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With repeated computations, intervals have a tendency to explode in both precision and size, leading to dramatic performance degradation. This PR changes
select_rootto reduce the precision of the interval as much as possible and then shrink it as much as possible.For example, my code bogs down on things like...
and
which my code doesn't under this change.
An alternative strategy would be to remove the shrinking phase and to refactor dyadic intervals to always consider the upper bound numerator to be the lower bound numerator plus one. I suspect that that would be a nice cleanup and reduce the amount of math required in general, but it would be a more in-depth refactor and a breaking change given that the interval code is public. I can try that out if you want...