Refactored ProfilePicture #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jan0707
commented
Aug 15, 2024
Jan0707
commented
- Removed state handling from component
- Made editable optionally
- Handled fallback state
- Handled image overwrite (new selection of profile picture)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Draft
Jan0707
commented
Aug 15, 2024
Jan0707
commented
Aug 15, 2024
dckz74
reviewed
Aug 16, 2024
| <div class="intro-text mb-2 mt-5 text-base font-light text-white md:text-4xl" v-html="introText"></div> | ||
| <div class="flex w-full flex-col items-center justify-center my-10"> | ||
| <ProfilePicture class="h-24 w-24 md:h-64 md:w-64" | ||
| :editable='true' |
Collaborator
There was a problem hiding this comment.
Nur ne kleine Info, es geht ja jetzt raus, aber damit du es mal für die Zukunft gehört hast:
Wenn man bools als prop fest auf true setzen möchte, kann man in Vue auch ganz easy nur :editable schreiben. Kleiner syntaktischer Zucker 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.