Skip to content

enforce 100% test coverage #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cameroncuster merged 8 commits into from
May 22, 2024
Merged

enforce 100% test coverage #23

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a35ad13
now update CI
lrvideckis May 22, 2024
9e7d7d6
debug
lrvideckis May 22, 2024
9ba321d
fix bug
lrvideckis May 22, 2024
5429603
revert
lrvideckis May 22, 2024
a2c3710
now fail CI on <100% coverage
lrvideckis May 22, 2024
bb2c201
remove one line of dead code
lrvideckis May 22, 2024
ea044ac
revert now
lrvideckis May 22, 2024
154512f
shorten
lrvideckis May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ on: [push, workflow_dispatch]

env:
CARGO_TERM_COLOR: always
# causes CI to fail on any warning
RUSTFLAGS: -D warnings
# `-D warnings` causes CI to fail on any warning
RUSTFLAGS: -D warnings -C instrument-coverage -C link-dead-code
RUSTDOCFLAGS: -D warnings

jobs:
Expand Down Expand Up @@ -36,6 +36,8 @@ jobs:
rustup install nightly
rustup override set nightly
rustup component add --toolchain nightly rustfmt clippy
cargo install cargo-binutils
rustup component add llvm-tools-preview
- name: install oj-verify submodule
run: |
git submodule init
Expand All @@ -46,8 +48,6 @@ jobs:
# clear submodule afterwards to not run tests in verification-helper
git submodule deinit --all -f
- name: run tests
# regarging `--tle 2`: the oj-verify tool only allows testing in release mode
#
# regarding `--jobs 4`: github CI runs with 4 cores
# https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
#
Expand All @@ -61,3 +61,9 @@ jobs:
# since all tests are rerun on every commit anyways, there's no need for
# the .verify-helper/timestamps.remote.json file
run: oj-verify all --tle 10 --jobs 4 --timeout 21600
# https://doc.rust-lang.org/rustc/instrument-coverage.html
- name: code coverage
run: |
cargo profdata -- merge -sparse default_*.profraw -o json5format.profdata
cargo cov -- report --use-color --ignore-filename-regex='/.cargo/registry' --instr-profile=json5format.profdata $(find target/debug/examples -type f -executable)
cargo cov -- export --ignore-filename-regex='/.cargo/registry' --instr-profile=json5format.profdata $(find target/debug/examples -type f -executable) | python -c "import sys, json; l=json.load(sys.stdin)['data'][0]['totals']['lines']; assert(l['count'] == l['covered'])"