Merged
Conversation
Member
Author
|
slightly better constant factor |
Member
cameroncuster
left a comment
cameroncuster
left a comment
There was a problem hiding this comment.
this is less clean, how much faster is it really?
Member
Author
|
just tested in release, the difference is negligible; dang, but it does kinda bug me that it's not as efficient as it could be in theory |
Member
Author
|
principle: minimize lifetime of variables |
cameroncuster
approved these changes
May 30, 2024
lrvideckis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.