refactor: 봉사 모집글 참여(Recruitment Participation) 도메인 리팩토링#112
Merged
BonSik-Koo merged 26 commits intodevelopfrom Feb 28, 2024
Merged
refactor: 봉사 모집글 참여(Recruitment Participation) 도메인 리팩토링#112BonSik-Koo merged 26 commits intodevelopfrom
BonSik-Koo merged 26 commits intodevelopfrom
Conversation
ojino88
approved these changes
Feb 27, 2024
Collaborator
ojino88
left a comment
ojino88
left a comment
There was a problem hiding this comment.
본식님 수고하셨어요~ PR요청때 정리해주신 덕분에 그 부분을 더 깊게 볼수있었던 것 같아요!
| @Override | ||
| public void cancelJoin(final User user, final Recruitment recruitment) { | ||
| RecruitmentParticipation recruitmentParticipation = findRecruitmentParticipation(recruitment, user); | ||
| checkCancelPossible(recruitmentParticipation); |
Collaborator
There was a problem hiding this comment.
행위와 검증 분리가 확실히 가독성이나 유지보수에 좋은것 같아요 ㅎㅎ
| } | ||
|
|
||
| public void increaseParticipationNum(int addParticipationNum) { | ||
| validateRemainingParticipationCapacity(addParticipationNum); |
Collaborator
There was a problem hiding this comment.
서비스 레이어에서 하던 검증을 도메인에서 하는것도 역할이 명확해지는 것 같아서 좋은것 같습니다~ 본식님 덕분에 service 레이어의 역할에 대해 깊게 고민해볼 수 있었어요 ㅎㅎ 감사합니다~
Member
Author
There was a problem hiding this comment.
아니예요~~ 저도 리팩토링하면서 객체지향 프로그래밍을 고민하다보니 쉽지 않네요 ㅎㅎ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #111
리팩토링 사항
참고사항