Skip to content

Fix hard coded version in zap command#40

Merged
hasty merged 1 commit into
project-chip:mainfrom
zaid-google:fix_version_in_zap
Nov 7, 2025
Merged

Fix hard coded version in zap command#40
hasty merged 1 commit into
project-chip:mainfrom
zaid-google:fix_version_in_zap

Conversation

@zaid-google
Copy link
Copy Markdown
Contributor

Summary

Fix the version being hard coded in the zap command. This will now take the version number from the config when creating the comment on xml docs showing the alchemy version used.

Testing

Ran alchemy zap command and checked the XML docs were displaying the correct version.

@zaid-google zaid-google requested a review from a team as a code owner November 7, 2025 20:58
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @zaid-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the zap command was embedding a static, hardcoded version number into comments within generated XML documentation. The change updates the command to retrieve the Alchemy version dynamically from the configuration system, ensuring that all generated XML documents accurately display the current version. This improves maintainability and prevents outdated version information from being propagated.

Highlights

  • Dynamic Versioning: The hardcoded Alchemy version string (v1.5.50) used in the zap command has been replaced with a dynamic call to config.Version(), ensuring the correct version is always reflected.
  • Dependency Update: The github.com/project-chip/alchemy/config package was imported to facilitate fetching the version dynamically.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly replaces a hardcoded version string with a dynamic call to config.Version(), improving maintainability. The change is straightforward and achieves its goal. I've added one comment regarding the version string format to ensure consistency with the previous implementation.

Comment thread zap/render/version.go
@hasty hasty merged commit ba4ee57 into project-chip:main Nov 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants