Skip to content

Alchemy discoballed directive#62

Merged
AryaHassanli merged 4 commits intoproject-chip:mainfrom
AryaHassanli:alchemy-discoballed-directive
Apr 23, 2026
Merged

Alchemy discoballed directive#62
AryaHassanli merged 4 commits intoproject-chip:mainfrom
AryaHassanli:alchemy-discoballed-directive

Conversation

@AryaHassanli
Copy link
Copy Markdown
Contributor

  • Introduce the :alchemy-discoballed: directive; files with this directive at the top are considered already discoballed.
  • Update disco templates to suggest optional fixes and enforce mandatory ones.
  • Implement logic to distinguish between optional and mandatory fixes. Mandatory fixes apply to files that either have the :alchemy-discoballed: directive or are newly added to the repository.

@AryaHassanli AryaHassanli requested a review from a team as a code owner April 13, 2026 18:45
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a tiered enforcement system for 'disco-ball' suggestions, distinguishing between mandatory and optional fixes based on whether a file is new or already contains the :alchemy-discoballed: marker. Key changes include updating the GitHub Action to handle multiple patch outputs, introducing a combined template for PR comments, and automating the placement of the marker at the top of files. Review feedback identified critical issues regarding potential nil pointer dereferences in GitHub API interactions, imprecise marker detection logic, and the incorrect application of os.ModeAppend when writing patch files.

Comment thread cmd/action/github/pr.go
Comment thread cmd/action/disco.go Outdated
Comment thread cmd/action/disco.go Outdated
Comment thread cmd/action/disco.go Outdated
@AryaHassanli AryaHassanli merged commit 61c8f88 into project-chip:main Apr 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant