added "--latest" to build docker image#102
added "--latest" to build docker image#102hiltonlima wants to merge 1 commit intoproject-chip:mainfrom hiltonlima:fix_auto_install_script
Conversation
hiltonlima
requested review from
antonio-amjr,
ccruzagralopes,
fabiowmm and
rquidute
|
Actually, with public images, I don't think we should have What do you think? |
Good morning @mikaelhm, I partially agree. We currently have the structure to use public Docker images. However, we don't actually have this working, as the images are not on any server, right? What I thought here is that we could remove the build from the auto-install images and call the build script separately. Thinking about a clean installation... Maybe we need to divide the auto-install into two parts? Prerequisites and then updating the sampleapps (SDK)? |
Actually this separation will be needed anyway to modularize TH for supporting different test programs. Some of the prereqs as well as the sample apps need to move out of the core and into the Matter Program (matter collection). |
|
Apollogies for the delay @hiltonlima. The docker images are already public, and we should have user use those. By default on the main brach, we can have the |
|
This PR is not needed anymore |
* [PICS_V2_SUPPORT]Db changes for certification mode and mandatory test collections and test suites (#101) * Db changes for certification mode and mandatory test collections and test suites * Fix code formating * Fix mypy violation * Update alembic/versions/e2c185af1226_pics_v2_support.py * [PICS_V2_SUPPORT] Endpoints changes in order to support certification mode and mandatory Test and suites (#102) * Db changes for certification mode and mandatory test collections and test suites * Fix code formating * Fix mypy violation * Update endpoints to support certification mode and mandatory test collection and suite * Minor fix * Added mandatory word to be considered as a valid word * Fix typo * Fix mypy violations * Fixed mypy violation * Remove unused import * Apply suggestions from code review Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Fixes after code review * Fix long line violation --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * [PICS_V2_SUPPORT] Update suite and test metadata to support mandatory field (#104) * Db changes for certification mode and mandatory test collections and test suites * Fix code formating * Fix mypy violation * Update endpoints to support certification mode and mandatory test collection and suite * Minor fix * Added mandatory word to be considered as a valid word * Fix typo * Fix mypy violations * Fixed mypy violation * Remove unused import * Update test and suite metadata to support mandatory field * [PICS_V2_SUPPORT] PICS V2 Unit tests added (#105) * Unit tests added * Unit test fixes * Unit test fixes * Unit test fixes. Mypy violations * Cancel test execution if one of the mandatory test cases fail on certification mode (#111) * Fix alembic file for pics v2 support * Fixes when a mandatory suite fails * Update any for statement * Display prompt when a mandatory test fails and causes test run cancellation in certification mode * Fix mypy issues * Apply review suggestion --------- Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> * Add support for test not applicable (#113) * Initial version for not_applicable hook * Update hook methods * Minor fixes test_skipped method * Skip to log step when test case is not applicable * Undo workaround for duration type * Fix line too long issue * Don't mark test case execution as finished before the time * Fix moment of step change * Fix test suite and test run state when all test cases are not applicable * Add space * Remove unused imports * Add and update unit tests * Fix isort issue --------- Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> --------- Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> Co-authored-by: Romulo Quidute Filho <rquidute@apple.com>
6 participants
By adding the
--latestparameter the.sha_informationfile is filled correctly.Issue: #98