Verify docker.download.com is reachable before attempting to install the Docker Package Repo in 1-install-dependencies.sh#270
Merged
raul-marquez-csa merged 9 commits intoproject-chip:v2.10+spring2024from Jun 3, 2024
Conversation
Updated `curl -fsSL https://download.docker.com/linux/ubuntu/gpg` To `curl -4fsSL https://download.docker.com/linux/ubuntu/gpg` This forces curl to use IPv4 addresses only, excluding IPv6. This has randomly caused the curl call to fail, failing the TH installation. Solution taken from this Stackoverflow thread https://stackoverflow.com/questions/48056566/could-not-resolve-host-download-docker-com-while-installing-docker-ce
raul-marquez-csa
requested review from
antonio-amjr,
cecille,
fabiowmm,
hiltonlima and
sammachin
hiltonlima
reviewed
May 30, 2024
hiltonlima
reviewed
May 30, 2024
Contributor
hiltonlima
left a comment
hiltonlima
left a comment
There was a problem hiding this comment.
We will soon release the new version of TH.
This version is in the fall2024 branch.
There we have already made some changes to the scripts that you are suggesting to change in this PR. Could you change the target of this PR to the fall2024 branch?
Adds explanation to retry logic
raul-marquez-csa
changed the title
hiltonlima
approved these changes
Jun 3, 2024
rquidute
approved these changes
Jun 3, 2024
antonio-amjr
approved these changes
Jun 3, 2024
Contributor
|
All good :) |
hiltonlima
pushed a commit
that referenced
this pull request
Jun 5, 2024
…the Docker Package Repo in 1-install-dependencies.sh (#270) * Update 1-install-dependendcies.sh docker curl Updated `curl -fsSL https://download.docker.com/linux/ubuntu/gpg` To `curl -4fsSL https://download.docker.com/linux/ubuntu/gpg` This forces curl to use IPv4 addresses only, excluding IPv6. This has randomly caused the curl call to fail, failing the TH installation. Solution taken from this Stackoverflow thread https://stackoverflow.com/questions/48056566/could-not-resolve-host-download-docker-com-while-installing-docker-ce * Update 1-install-dependendcies.sh * Update 1-install-dependendcies.sh - testing * testing * testing * testing * Restores install-pi-dependencies.sh and auto-install.sh Adds explanation to retry logic * Missed including this file.... (cherry picked from commit de65367)
| # Install Docker Package Repo | ||
| curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor --yes -o /usr/share/keyrings/docker-archive-keyring.gpg | ||
| echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker.list > /dev/null | ||
| curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor --yes -o /usr/share/keyrings/docker-archive-keyring.gpgecho "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker.list > /dev/null |
There was a problem hiding this comment.
The lost line feed between these two lines caused the script to fail.
hiltonlima
pushed a commit
that referenced
this pull request
Jun 12, 2024
…the Docker Package Repo in 1-install-dependencies.sh (#270) * Update 1-install-dependendcies.sh docker curl Updated `curl -fsSL https://download.docker.com/linux/ubuntu/gpg` To `curl -4fsSL https://download.docker.com/linux/ubuntu/gpg` This forces curl to use IPv4 addresses only, excluding IPv6. This has randomly caused the curl call to fail, failing the TH installation. Solution taken from this Stackoverflow thread https://stackoverflow.com/questions/48056566/could-not-resolve-host-download-docker-com-while-installing-docker-ce * Update 1-install-dependendcies.sh * Update 1-install-dependendcies.sh - testing * testing * testing * testing * Restores install-pi-dependencies.sh and auto-install.sh Adds explanation to retry logic * Missed including this file.... (cherry picked from commit de65367)
raul-marquez-csa
added a commit
that referenced
this pull request
Jul 4, 2024
* Fixed image tag for both frontend and backend * Updated sample semi-automated command (#190) * Update Matter_TH_User_Guide.adoc * Add files via upload * Updated backend SHA (#193) * Updated backend SHA in docker-compose file * Change the user guide to emphasize the new distribution method. (#197) * user guide adjustements for the new distribution approach. * Update docs/Matter_TH_User_Guide/Matter_TH_User_Guide.adoc Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Add data model mapping to docker command (#199) * Update user guide with data model volume mapping * Fix mapping * Updated backend submodule * Updated docker-compose * Update mapping in docker run command (#201) * Fix installation error: Remove libssl-dev version (#203) * Remove lib version * adding comments * Using satisfy * Using satisfy * uncomment the last line * remove unsed * Adding linux-modules-extra-raspi package * Updated backend * Updated backend submodule * Updated docker compose file * Revert backend sha in docker compose gile * Udated back sha in docker-compose file * Update backend * Fix: Backend tag into docker compose file (#236) * update docker compose fix update.sh to allow use tag withou branch linked * update backend commit * update backend commit * Update depedencies script * Update script improviment * Remove version (obsolete) * Update backend * update docker compose * Update user guide * Build docker iamges using cache * Update user guide (#251) * Fix libglib2.0-dev version * Verify docker.download.com is reachable before attempting to install the Docker Package Repo in 1-install-dependencies.sh (#270) * Update 1-install-dependendcies.sh docker curl Updated `curl -fsSL https://download.docker.com/linux/ubuntu/gpg` To `curl -4fsSL https://download.docker.com/linux/ubuntu/gpg` This forces curl to use IPv4 addresses only, excluding IPv6. This has randomly caused the curl call to fail, failing the TH installation. Solution taken from this Stackoverflow thread https://stackoverflow.com/questions/48056566/could-not-resolve-host-download-docker-com-while-installing-docker-ce * Update 1-install-dependendcies.sh * Update 1-install-dependendcies.sh - testing * testing * testing * testing * Restores install-pi-dependencies.sh and auto-install.sh Adds explanation to retry logic * Missed including this file.... * Fix docker installation (#277) (cherry picked from commit 2209d25) * Update backend Commit SHA * Update docker image tag * update release links * Update TH user guide * Update backend SHA * Update user guide * Update user guide * Update backend tag * Fix / update TH version info * Adds db version info to th version info * Adds proxy version info to TH version info * Fixes commit message breaking the borders when multiline or too long * Adds storage info to system information * Splits os and network info into their own cmd arguments * Adds usage at the end of any info * Fix backend and frontend container names * Adds extra error message info * Updates TH components labels * Refactors version info, adds container running check * Removes docker containers script as it's redundant now * Renames os script to th-system * Renames network script to th-network * Updates usage text and labels * Minor error message update * Adds new option to show docker logs * Renames th-net-dut script to th-dut * Updated label to docker compose version * Removes unused comment * Updates config.py file location (evaluates 2 locations) * Gets fall2024 files * Restores .gitmodules * Restores .gitmodules * Sets test_collections/matter/config.py as only file location --------- Co-authored-by: Hilton Lima <hilton_lima@apple.com> Co-authored-by: Suraj Seenivasan <suraj@graniteriverlabs.in> Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> Co-authored-by: fabiowmm <116586985+fabiowmm@users.noreply.github.com> Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com>
hiltonlima
added a commit
that referenced
this pull request
Aug 16, 2024
* Suport for Ubuntu Server 24.04 LTS (#280) * update packages version * auto-install script refactoring * Add wifi connect helper script * Adding commom ble packages * Update scripts/pi-setup/install-pi-dependencies.sh * Improving docker instalation script * Improving scripts log * Improving scripts log * Improving scripts log * remove unused code * improve utils script * improve utils script * fix order * PR review * PR review * Update backend SHA * Fix CLI dependencies installation * Fix CLI dependencies installation * update backend sha * update backend sha * update backend sha * Do not use apt in bash * update backend sha * Update backend sha * Update scripts/ubuntu/auto-update.sh Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * TH Doctor Update - July 2024 (#305) * Fixed image tag for both frontend and backend * Updated sample semi-automated command (#190) * Update Matter_TH_User_Guide.adoc * Add files via upload * Updated backend SHA (#193) * Updated backend SHA in docker-compose file * Change the user guide to emphasize the new distribution method. (#197) * user guide adjustements for the new distribution approach. * Update docs/Matter_TH_User_Guide/Matter_TH_User_Guide.adoc Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Add data model mapping to docker command (#199) * Update user guide with data model volume mapping * Fix mapping * Updated backend submodule * Updated docker-compose * Update mapping in docker run command (#201) * Fix installation error: Remove libssl-dev version (#203) * Remove lib version * adding comments * Using satisfy * Using satisfy * uncomment the last line * remove unsed * Adding linux-modules-extra-raspi package * Updated backend * Updated backend submodule * Updated docker compose file * Revert backend sha in docker compose gile * Udated back sha in docker-compose file * Update backend * Fix: Backend tag into docker compose file (#236) * update docker compose fix update.sh to allow use tag withou branch linked * update backend commit * update backend commit * Update depedencies script * Update script improviment * Remove version (obsolete) * Update backend * update docker compose * Update user guide * Build docker iamges using cache * Update user guide (#251) * Fix libglib2.0-dev version * Verify docker.download.com is reachable before attempting to install the Docker Package Repo in 1-install-dependencies.sh (#270) * Update 1-install-dependendcies.sh docker curl Updated `curl -fsSL https://download.docker.com/linux/ubuntu/gpg` To `curl -4fsSL https://download.docker.com/linux/ubuntu/gpg` This forces curl to use IPv4 addresses only, excluding IPv6. This has randomly caused the curl call to fail, failing the TH installation. Solution taken from this Stackoverflow thread https://stackoverflow.com/questions/48056566/could-not-resolve-host-download-docker-com-while-installing-docker-ce * Update 1-install-dependendcies.sh * Update 1-install-dependendcies.sh - testing * testing * testing * testing * Restores install-pi-dependencies.sh and auto-install.sh Adds explanation to retry logic * Missed including this file.... * Fix docker installation (#277) (cherry picked from commit 2209d25) * Update backend Commit SHA * Update docker image tag * update release links * Update TH user guide * Update backend SHA * Update user guide * Update user guide * Update backend tag * Fix / update TH version info * Adds db version info to th version info * Adds proxy version info to TH version info * Fixes commit message breaking the borders when multiline or too long * Adds storage info to system information * Splits os and network info into their own cmd arguments * Adds usage at the end of any info * Fix backend and frontend container names * Adds extra error message info * Updates TH components labels * Refactors version info, adds container running check * Removes docker containers script as it's redundant now * Renames os script to th-system * Renames network script to th-network * Updates usage text and labels * Minor error message update * Adds new option to show docker logs * Renames th-net-dut script to th-dut * Updated label to docker compose version * Removes unused comment * Updates config.py file location (evaluates 2 locations) * Gets fall2024 files * Restores .gitmodules * Restores .gitmodules * Sets test_collections/matter/config.py as only file location --------- Co-authored-by: Hilton Lima <hilton_lima@apple.com> Co-authored-by: Suraj Seenivasan <suraj@graniteriverlabs.in> Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> Co-authored-by: fabiowmm <116586985+fabiowmm@users.noreply.github.com> Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> * Update Backend SHA * Update backend SHA * Version readability improvments * Update backend sha * Ubuntu 22.04 is not more supported (#321) * check ubuntu version * update backend sha * fix validation * Update error message * Update backend sha * Update User Guide with info about Certification Mode (#329) * Update User Guide With New Ubuntu Version (#318) * Update the User Guide with the new Ubuntu version * Update the User Guide PDF file * Update backend sha * Update Backend SHA * Update frontend * Update frontend SHA * update docker compose * Update backend SHA --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> Co-authored-by: Raul Marquez <130402456+raul-marquez-csa@users.noreply.github.com> Co-authored-by: Suraj Seenivasan <suraj@graniteriverlabs.in> Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> Co-authored-by: fabiowmm <116586985+fabiowmm@users.noreply.github.com> Co-authored-by: Raul Marquez <rmarquez@csa-iot.org> Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com>
hiltonlima
added a commit
that referenced
this pull request
Aug 27, 2024
* Suport for Ubuntu Server 24.04 LTS (#280) * update packages version * auto-install script refactoring * Add wifi connect helper script * Adding commom ble packages * Update scripts/pi-setup/install-pi-dependencies.sh * Improving docker instalation script * Improving scripts log * Improving scripts log * Improving scripts log * remove unused code * improve utils script * improve utils script * fix order * PR review * PR review * Update backend SHA * Fix CLI dependencies installation * Fix CLI dependencies installation * update backend sha * update backend sha * update backend sha * Do not use apt in bash * update backend sha * Update backend sha * Update scripts/ubuntu/auto-update.sh Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * TH Doctor Update - July 2024 (#305) * Fixed image tag for both frontend and backend * Updated sample semi-automated command (#190) * Update Matter_TH_User_Guide.adoc * Add files via upload * Updated backend SHA (#193) * Updated backend SHA in docker-compose file * Change the user guide to emphasize the new distribution method. (#197) * user guide adjustements for the new distribution approach. * Update docs/Matter_TH_User_Guide/Matter_TH_User_Guide.adoc Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Add data model mapping to docker command (#199) * Update user guide with data model volume mapping * Fix mapping * Updated backend submodule * Updated docker-compose * Update mapping in docker run command (#201) * Fix installation error: Remove libssl-dev version (#203) * Remove lib version * adding comments * Using satisfy * Using satisfy * uncomment the last line * remove unsed * Adding linux-modules-extra-raspi package * Updated backend * Updated backend submodule * Updated docker compose file * Revert backend sha in docker compose gile * Udated back sha in docker-compose file * Update backend * Fix: Backend tag into docker compose file (#236) * update docker compose fix update.sh to allow use tag withou branch linked * update backend commit * update backend commit * Update depedencies script * Update script improviment * Remove version (obsolete) * Update backend * update docker compose * Update user guide * Build docker iamges using cache * Update user guide (#251) * Fix libglib2.0-dev version * Verify docker.download.com is reachable before attempting to install the Docker Package Repo in 1-install-dependencies.sh (#270) * Update 1-install-dependendcies.sh docker curl Updated `curl -fsSL https://download.docker.com/linux/ubuntu/gpg` To `curl -4fsSL https://download.docker.com/linux/ubuntu/gpg` This forces curl to use IPv4 addresses only, excluding IPv6. This has randomly caused the curl call to fail, failing the TH installation. Solution taken from this Stackoverflow thread https://stackoverflow.com/questions/48056566/could-not-resolve-host-download-docker-com-while-installing-docker-ce * Update 1-install-dependendcies.sh * Update 1-install-dependendcies.sh - testing * testing * testing * testing * Restores install-pi-dependencies.sh and auto-install.sh Adds explanation to retry logic * Missed including this file.... * Fix docker installation (#277) (cherry picked from commit 2209d25) * Update backend Commit SHA * Update docker image tag * update release links * Update TH user guide * Update backend SHA * Update user guide * Update user guide * Update backend tag * Fix / update TH version info * Adds db version info to th version info * Adds proxy version info to TH version info * Fixes commit message breaking the borders when multiline or too long * Adds storage info to system information * Splits os and network info into their own cmd arguments * Adds usage at the end of any info * Fix backend and frontend container names * Adds extra error message info * Updates TH components labels * Refactors version info, adds container running check * Removes docker containers script as it's redundant now * Renames os script to th-system * Renames network script to th-network * Updates usage text and labels * Minor error message update * Adds new option to show docker logs * Renames th-net-dut script to th-dut * Updated label to docker compose version * Removes unused comment * Updates config.py file location (evaluates 2 locations) * Gets fall2024 files * Restores .gitmodules * Restores .gitmodules * Sets test_collections/matter/config.py as only file location --------- Co-authored-by: Hilton Lima <hilton_lima@apple.com> Co-authored-by: Suraj Seenivasan <suraj@graniteriverlabs.in> Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> Co-authored-by: fabiowmm <116586985+fabiowmm@users.noreply.github.com> Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> * Update Backend SHA * Update backend SHA * Version readability improvments * Update backend sha * Ubuntu 22.04 is not more supported (#321) * check ubuntu version * update backend sha * fix validation * Update error message * Update backend sha * Update User Guide with info about Certification Mode (#329) * Update User Guide With New Ubuntu Version (#318) * Update the User Guide with the new Ubuntu version * Update the User Guide PDF file * Update backend sha * Update Backend SHA * Update frontend * Update frontend SHA * update docker compose * Update backend SHA --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> Co-authored-by: Raul Marquez <130402456+raul-marquez-csa@users.noreply.github.com> Co-authored-by: Suraj Seenivasan <suraj@graniteriverlabs.in> Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> Co-authored-by: fabiowmm <116586985+fabiowmm@users.noreply.github.com> Co-authored-by: Raul Marquez <rmarquez@csa-iot.org> Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The network randomly fails after the service restarts that happen before installing the Docker Package Repo, this ultimately makes the TH installation fail.
A ping to
docker.download.comwill be attempted and retried in increments of 1 second before a 5 minute timeout.