[Fix] CLI Project Config Issue and More#820
Conversation
Also adding the Unsupport Message for Two Way Talk Camera feature for CLI
Summary of ChangesHello @antonio-amjr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates recent updates from the 'certification-tool-backend' and 'certification-tool-cli' submodules into the main project. It addresses a reported issue by incorporating fixes related to project configuration execution and adds support for an unsupported message for the Two Way Talk Camera feature in the CLI. The 'docker-compose.yml' file has also been updated to align with the new backend image version. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the backend and cli submodules to their latest respective commits, addressing the issues and enhancements mentioned in the description, including CLI fixes for project configuration and unsupported message handling. The docker-compose.yml file has also been updated to reflect the new backend image SHA, ensuring consistency with the submodule updates.
4458b45
into
project-chip:v2.15-beta2+spring2026-develop
* Fixing long delay on Python Tests and overall performance by removing the start-reload script. (#465) This solution exchanges the start-reload script with a direct call of the main.py file from the docker compose file * fix typo: linux/arm64 (#445) * User guide: Fix command to execute sdk container (#428) * fix command to execute sdk container (cherry picked from commit 8df12b8) * Reset pdf file to spring2025 * update history (#425) Update nrutil link Update dongle instructions * Updated backend sha * Updated backend sha * Updated CLI and backend submodules * Merge fall v2.11+fall2024 * Fixed after merge * Updated backend * docs: Update Ubuntu version to 24.04.1 in TH User Guide (#512) Update the Ubuntu version reference to 24.04.1 as this is now the only available option in the Raspberry Pi Imager for Ubuntu Server 24.04 LTS. * Updated backend * Updated backend * UG- Added Reuse commissioning information section (#514) * UG- Added Reuse commissioning information section * Update docs/Matter_TH_User_Guide/Matter_TH_User_Guide.adoc * Update docs/Matter_TH_User_Guide/Matter_TH_User_Guide.adoc * updated UG PDF * Update README.md (#511) fix typo in SD card description * [FIX] Update Network Check Method In Installation Script (#517) * Updating docker's network connectivity on installation script * Fixing identation of file * Create log files for installation scripts (#518) * add log stuff * fix auto install * fix auto install * ignore instalation logs * fix auto install * Updated backend and cli * Updated backend sha in docker-compose file * Updated backend * Updating CLI with the Poetry install fix and some minor changes (#524) * Version v2.12-beta1+spring2025 * Updated backend * Fixing auto-update script with error check (#528) * Version v2.12-beta2+spring2025 * Version v2.12-beta3+spring2025 * Undo changes in auto-update.sh file * Fix cli dependency syntax * Upgraded node version to v20.x * Updated frontend - performance * Updating HASHs and docker compose (#519) * Updating backend HASH (#521) * Updated backend sha * docs: add "timeout" to Test Parameters section (#522) * docs: add "timeout" to Test Parameters section * docs: generate pdf * Updating backend SHA and docker compose * Updated backend cli and frontend * Updated backend * Updated backend * Updated backend * Updated backend * Updated backend and frontend - performance ui was missing * Updating once more the Backend SHA and Docker compose * Updating Backend (#542) * Updating Backend SHA and the Docker Compose * UG - Updated Ubuntu supported version * Updating User guide replacing the patch number of the Ubuntu version. Replaced with a 'x' variable to avoid constant updates. --------- Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> * Improve TH start script (#544) * Send standard and error outputs to a log file * Move log files to logs folder * Updated backend * Updated docker-compose * Updated User Guide for v2.13-beta2+summer2025 * Updating the backend tree with two commits from the develop branch (#555) * Add poetry self update for cli installation (#558) * Updated backend SHA - Feature/530 mock server available (#561) * Updated backend - Mock Server * Updated backend - Mock Server * [UG] - Added Mapped Volumes (#566) * Merge v2.12+spring2025 UG * Added mapped volumes section * Update docs/Matter_TH_User_Guide/Matter_TH_User_Guide.adoc Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Update docs/Matter_TH_User_Guide/Matter_TH_User_Guide.adoc Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> * Code review --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> * Updated backend - Platform cert implementation * Updated backend and cli * [FIX] Fix start.sh script to log front back launching log (#581) * Fix start script to log front/back startup logs * Apply suggestions from code review Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> * Code review * Update scripts/start.sh Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> --------- Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Created sideload script (#583) * Updated backend sha * [User Guide]Added Platform certification configuration section (#575) * Added Platform certification section in UG * Code review * Code review * Merge V2.13 beta3.3+summer2025 to V2.13+summer2025-develop (#613) * Update user guider for 1.5 te2 version * Updated version information * Updated backend - Fix Yaml * Fixes for v2.13-beta3.1+summer2025 * Version v2.13-beta3.1+summer2025 * Updating Backend SHA with step manual fix * Updating Backend SHA with new version information and the UG * Updating Backend SHA with new version information and the UG * Adding the Wi-Fi PAF documentation to the User Guide (#596) --------- Co-authored-by: Antonio Melo Jr. <a_junior@apple.com> Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> * [FIX] Fix UG links to use members-all links (#614) * Update user guider for 1.5 te2 version * Updated version information * Updated backend - Fix Yaml * Fixes for v2.13-beta3.1+summer2025 * Version v2.13-beta3.1+summer2025 * Updating Backend SHA with step manual fix * Updating Backend SHA with new version information and the UG * Updating Backend SHA with new version information and the UG * Adding the Wi-Fi PAF documentation to the User Guide (#596) * Replaced matter-csg links to members-all links * Merge * Minor changes in text --------- Co-authored-by: Antonio Melo Jr. <a_junior@apple.com> Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> * Map ports for certification-tool-backend container to listen to H264 packets from camera-controller (#576) Signed-off-by: Sathvik K Gatti <s.gatti@samsung.com> Signed-off-by: Suyambulingam Rathinasamy Muthupandi <suyambu.rm@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Co-authored-by: s-gatti <s.gatti@samsung.com> * Changed for v2.14-beta1+fall2025 version * Fixed config.py file location (#657) * Updating the User Guide, Backend SHA and docker compose to the release (#660) * [Docs] [Camera] Updating User Guide With Camera Information (#666) * Updating the User Guide with camera related information * Apply suggestion from @antonio-amjr Improve readability for apt install command * Apply suggestion from @antonio-amjr Improving text using navigate term, replacing quotes symbols and adding missing backtick * Apply suggestion from @antonio-amjr Adds missing 5 from release version * Apply suggestion from @antonio-amjr Improving Run Camera Test Cases section description * Apply suggestion from @antonio-amjr Adds missing 's' from commands since there are multiple listed * Improving the 'Running chip-camera-app with USB Camera' section description * Updating and reformating TH Links and References sections * [Fix] User Guide Broken Images The images from the User Guide are not being presented while accessing through the site. This change removes the absolute path configured with the :imagesdir: from ADOC file to force the file to use the relative path and correctly access the images folder. * Fixes raised by Gemini in PR #797 (#725) * Minor changes raised by gamini in PR#797 * Update scripts/sideload.sh Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update scripts/start.sh Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update scripts/start.sh Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update docs/Matter_TH_User_Guide/Matter_TH_User_Guide.adoc Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * [Camera] Add pushav-service to proxy https requests by skipping ssl verification (#728) * Add pushav-service to proxy http->https requests by skipping ssl verifications Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * Use host docker name instead of hardcoded IP Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> --------- Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Signed-off-by: s-gatti <s.gatti@samsung.com> Co-authored-by: s-gatti <s.gatti@samsung.com> * Version v2.14-beta2.1+fall2025 * Updated cli * v2.14-beta2.1+fall2025 frontend camera fixes * Updated frontend * Install additional dependencies during update and fresh installation (#759) * Install additional dependencies during update and fresh installation * Updated additional-dependency-list.txt file * Update scripts/ubuntu/1.2-install-additional-dependencies.sh Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Added missing UBUNTU_SCRIPT_DIR to internal-auto-update.sh script file * Debug error * Removed echo debug * Updated script to run the updated script in case the file is updated after Update Test Harness code step * Reverting some changes * Update auto-update logic --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Fixed submodules SHA and user guide * Updated Matter version in User guide * V2.14 beta3 new version (#764) * Changes for v2.14-beta3+fall205 version * Updated backend SHA in docker-compose.yml * Update docs/Matter_TH_User_Guide/Matter_TH_User_Guide.adoc Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> * Code review * Code review * Updated backend --------- Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> * Updated backend - list python scripts * Updating TH CLI installationto use the new CLI install script (#738) * Updated backend - List misssing python scripts * Updated SDK_SHA after some scripts fixes * Adding solution for the CLI user prompt issue (#781) * Updating Backend SHA to add the Python Testing Initialization Improvement (#786) * Version v2.14+fall2025 * Updated backend. SDK SHA ca9d1118e097fe947b2aec1ba84f265d6cf2447e * Fix fresh installation issue in fall2024 version (#789) * Pin docker-ce to version <28.0.0 to prevent Traefik incompatibility * Updated docker-ce version * Fix Docker installation to exclude incompatible version 29.x * Update scripts/ubuntu/1-install-dependencies.sh Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update scripts/ubuntu/1-install-dependencies.sh Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Updated user guide with configurable real-time logging (#794) * Updating Backend SHA and Docker Compose file with the new value * [FIX] User Guide Fix For Matter 1.6 TE1 (#797) * Updating the user guide for Matter 1.6 TE1 (v2.15-beta1+winter2025) * Adding an example to the Side Load Sub-section step * Updating the doc revision table and the pdf file with the changes * Removing extra '+' from revision table in the .adoc file * Updating pdf with the current changes * Updated traefik to 3_6_1 and undo workaround to avoid installing Docker 29.* version (#800) * Updated traefix to 3_6_1 and undo workaround to avoid installing Docker 29.* version * Update scripts/ubuntu/1-install-dependencies.sh Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Changes after gemini code review * Updated minimum docker version --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * [Fix] Custom Naming and Links (#801) * Adding the custom Python/YAML naming fix and the folder links to the Matter 1.6 TE2 release * Improving Note text and adding the PDF file * Adding the CLI parser tag error fix to the Matter 1.6 TE2 release (#806) * Updated CLI for fix prompt_respons not defined (#807) * Fix _print_script_step command not found issue (#809) * Adding the CLI Fix to use project config while executing (#820) Also adding the Unsupport Message for Two Way Talk Camera feature for CLI * Fix Docker 29.x compatibility issues with Traefik - v1.6 (#819) * Fix Docker 29.x compatibility issues with Traefik * Make fix-docker-* script files executable * Code review * Updating SHAs to present Node IDs in the CLI's output (#829) Also, removing the Error colomn from the CLI's execution history * Fix installation failure for GStreamer development packages on Ubuntu 24.04 (#836) * Ensure ensure all dev packages are up to date to match installed library versions * Update scripts/ubuntu/1.2-install-additional-dependencies.sh Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * [Documentation] Add CLI to User Guide (#841) * Updating User Guide: Adding CLI section into the User Guide Document Also, updating Backend and CLI SHAs with recent changes * Including updates for issues #603 and #842 * Review feedbacks: adding missing commands, notes and 1 warning * Undo workaround for Docker 29.x compatibility issues with Traefik (#849) * Undo workaround for Docker 29.x compatibility issues with Traefik * Updated cli and backend submodules * Undo script removal since the update process should check for compatibility issue * Code review * Updated User Guide with configuration for container information logging (#847) * Added Container Logging Configuration section * Code review * Add OTA Image build procedure section in Matter user guide (#854) * Added Added OTA Image Build Procedure section * Code review * Code review * Fixed apps folder - code review * v2.15-beta2+spring2026 version * updated docker-compose.yml * Updating CLI SHA with a extra arguments fix * Stashing also untracked files when updating TH (#858) * Fix Matter version for 1.5.1 in User Guide (#861) * Fix Matter version for 1.5.1 * Version v2.14.1-beta1+winter2026 * Updated backend sha in docker-compose.yml file * Fix ota iamge folder in matter User Guide (#863) * Version v2.14.1-beta2+winter2026 * Version v2.14.1-beta2+winter2026 * Fix Matter version for Camera testing (#871) * Fix Matter version for Camera testing * Fix Matter version for Camera testing * Add documentation for thread commissioning (#868) * Added Thread Commissioning section in UG * Added Thread Commissioning section in UG * Code review * Updated references from thread to thread-meshcop * Updated th version for v1.6 * Version v2.15-beta2.1+spring2026 * v2.15-beta2.2+spring2026 version * Updated User guide - Test Logging Configuration section (#922) * Release Matter 1.6 SVE (#934) * Release Matter 1.6 SVE version 2 (#940) * Enhance user guide with NFC Device pairing instructions (#948) * Enhance user guide with NFC Device pairing instructions Added instructions for NFC Device pairing mode and configuration details. * Fix formatting in Matter TH User Guide * Update NFC Reader index example in user guide * Apply suggestions from code review Co-authored-by: Olivier LORENTE [ST] <34505085+OlivierGre@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Olivier LORENTE [ST] <34505085+OlivierGre@users.noreply.github.com> * Add NFC-WiFi Device Mode section to user guide * Added Revision history for the changes. Added details for nfc-thread and nfc-wifi pairing modes, as well as NFC Device Mode in the Project Configuration section. * Update Matter_TH_User_Guide.pdf for NFC documentation changes --------- Co-authored-by: Olivier LORENTE [ST] <34505085+OlivierGre@users.noreply.github.com> * Update nfc doc (#949) * Added information for NFC commissioning. * Updates * Fixes from code review * Updated X-NUCLEO-NFC11B2 ref. * Updated PDF * Add CLI requirement for side-loaded test cases (-custom suffix) in Section 4.5 (#976) * Enhance user guide for sideload test case with -custom suffix * Update Matter_TH_User_Guide.adoc * Added Revision history for the changes. * Add CLI requirement for side-loaded test cases (-custom suffix) in Section 4.5 * Added missing dependencies for chip-tool (#985) * Added missing dependencies for chip-tool * Code review * Code review - t64 versions * Code review - t64 versions. Undo +libpcsclite1t64 * Code review - t64 versions. Undo +libpcsclite1t64 * Updated Raspberry Pi prerequisites to specify minimum 8 GB RAM requirement (#987) * Fix intermittent installation failures - Matter v1.6 (#990) * Fix intermittent installation failures - Matter v1.6 * Code review - Gemini Code Assist * Added grouped log download documentation using CLI (#991) * Added grouped log download documentation using CLI * Removed unecessary note * Code review * Minor fix * Release Matter 1.6 Final Version (#996) * Updated docker-compose.yml * Updated backend - fix Module not found issue (#998) --------- Signed-off-by: Sathvik K Gatti <s.gatti@samsung.com> Signed-off-by: Suyambulingam Rathinasamy Muthupandi <suyambu.rm@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Signed-off-by: s-gatti <s.gatti@samsung.com> Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> Co-authored-by: rxwen <rx.wen218@gmail.com> Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> Co-authored-by: James Swan <122404367+swan-amazon@users.noreply.github.com> Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> Co-authored-by: Kiel Oleson <kielo@apple.com> Co-authored-by: rl-mediola <129751908+rl-mediola@users.noreply.github.com> Co-authored-by: Antonio Melo Jr. <a_junior@apple.com> Co-authored-by: Romulo Quidute Filho <rquidute@apple.cpom> Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> Co-authored-by: chulspro <chulspro.kim@samsung.com> Co-authored-by: s-gatti <s.gatti@samsung.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Pradeep-grl <pradeep.g@graniteriverlabs.in> Co-authored-by: Olivier LORENTE [ST] <34505085+OlivierGre@users.noreply.github.com> Co-authored-by: Sumith D <Sai.Sumith@grlps.com>
Fix: #816 (comment)
Description
Pulling some updates to Backend and CLI.
Updating SHAs and docker compose file.
Adding the CLI Fix to use project config while executing (PR#283 and PR#47)
Also adding the Unsupported Message for Two Way Talk Camera feature for CLI (PR#46)