feat: Terminal content search feature #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starpit
force-pushed
the
terminal-filter
branch
3 times, most recently
from
bbec0e5 to
f977487
Compare
starpit
added a commit
to starpit/codeflare-cli
that referenced
this pull request
Jul 5, 2022
We should instead use more specific search capabilities, such as project-codeflare#233
starpit
added a commit
that referenced
this pull request
Jul 5, 2022
We should instead use more specific search capabilities, such as #233
PabloCarmona
pushed a commit
to PabloCarmona/codeflare-cli
that referenced
this pull request
Jul 7, 2022
We should instead use more specific search capabilities, such as project-codeflare#233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a search box below the application logs. It allows for searching.
Fixes #179
Though that issue asks for filtering, and this provides search capability, I'll close that issue, for now. In order to do filtering, we would need to write an xterm.js addon. There is already an
xterm-addon-search, but noxterm-addon-filter. See: https://github.com/xtermjs/xterm.js/tree/master/addons