Skip to content

Conversation

@dgrove-oss
Copy link
Collaborator

  1. Go 1.22 has been released, meaning go 1.20 is out of support.
  2. Kueue and AppWrapper both have go 1.21 as their minimal version.

@openshift-ci openshift-ci bot requested review from KPostOffice and tedhtchang March 6, 2024 15:55
@openshift-ci
Copy link

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign astefanutti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several other instances where we could upgrade go versions too including

FROM registry.access.redhat.com/ubi8/go-toolset:1.20.10 as builder

and others, maybe the workflows go version used too.

@dgrove-oss
Copy link
Collaborator Author

I updated the workflow files.

It looks to me like there is no go 1.21 version of ubi8/go-toolset available yet. go-toolset 1.20.12 is the most recent tag I see.

@dgrove-oss
Copy link
Collaborator Author

Closing this. We're going to take a less incremental approach of migrating the code flare operator from MCADv1 to the new Kueue-capable AppWrapper. Will open a new PR when the larger step is ready to review.

@dgrove-oss dgrove-oss closed this Mar 13, 2024
@dgrove-oss dgrove-oss deleted the gobump branch March 13, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants