Skip to content

Conversation

@zdtsw
Copy link
Contributor

@zdtsw zdtsw commented Apr 23, 2024

Issue link

to prevent PR with new image gets merged and cause other parties falling their daily tasks.

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from KPostOffice and sutaakar April 23, 2024 11:50
@openshift-ci
Copy link

openshift-ci bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign christianzaccaria for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@astefanutti
Copy link
Contributor

/lgtm

Thanks!

@astefanutti
Copy link
Contributor

@sutaakar WDYT?

@sutaakar
Copy link
Contributor

I am considering better solution which will trigger image build automatically for a push event in ODH CFO repo.
Will create a PR today.

@sutaakar
Copy link
Contributor

This PR is replaced by opendatahub-io#53 , which was pushed directly into the repository.
Closing this PR.

@sutaakar sutaakar closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants