Skip to content

Conversation

@ChristianZaccaria
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria commented Nov 30, 2023

Issue link

Resolves #417

What changes have been made

  • Added pyarrow to the poetry dependencies.

Verification steps

  • Checkout this PR (or add the line of code to the pyproject.toml file on latest main branch)
  • Install codeflare-sdk in your kubernetes cluster. Probably easiest way is to run poetry build, then install the generated wheel with pip install codeflare_sdk-0.0.0.dev0-py3-none-any.whl.
  • Clone the codeflare-sdk repository.
  • Run through the guided-demo notebook 3_basic_interactive.ipynb where we will set in our ClusterConfiguration instascale to false and GPU to 0 as scaling doesn't occur before the error is encountered. Run the demo until the point where we run ray.init and make sure the Ray cluster is up and running.
  • No errors encountered.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Manual tests

Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through the notebook with and without pyarrow and can confirm that this fixes the issue.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 745772e into project-codeflare:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No module named "pyarrow"

3 participants