-
Notifications
You must be signed in to change notification settings - Fork 59
use route instead of ingress for oauth endpoint #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use route instead of ingress for oauth endpoint #437
Conversation
5060506 to
eb78f79
Compare
|
@KPostOffice While testing this changes got below error at the step cluster.up() |
ChristianZaccaria
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed during scrum, perhaps we would want to re-introduce the port_name and host for oauth route objects. Other than that, and Srihari's finding, this is a solid PR. Great job!
0b20c74 to
175d0d2
Compare
Signed-off-by: Kevin <kpostlet@redhat.com>
175d0d2 to
4438c78
Compare
Srihari1192
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
ChristianZaccaria
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm great job!
|
/approve 🤫 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChristianZaccaria, KPostOffice, Srihari1192 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
fixes: #436
fixes: #414
What changes have been made
Verification steps
Checks