Updating tls encryption for ray dashboard route

[Fiona-Waters]

Issue link

Resolves RHOAIENG-66
Resolves RHOAIENG-12

By default the dashboard route tls termination will be set to edge. The route is secured (https) with the Let’s Encrypt cert. The dashboard works as expected.

From what I can see, it is not possible to use reencrypt here with the dashboard route as Ray is not using a cert on the dashboard port. I think edge is a good option here.

When openshift_oauth = true, we will set the tls termination to reencrypt. This means that the oauth self signed cert will not be exposed.

What changes have been made

When openshift_oauth = false the dashboard route will use edge tls termination.
When openshift_oauth = true the dashboard route will use reencrypt tls termination.

Verification steps

• On an OpenShift Cluster with RHOAI installed navigate to the RHOAI dashboard and start a Jupyter notebook server.
• Install codeflare sdk from my branch. In the terminal enter the following commands:

git clone https://github.com/Fiona-Waters/codeflare-sdk.git -b reencrypt
pip install poetry
cd codeflare-sdk
poetry install

• Choose a demo notebook
  1 - In the ClusterConfiguration set openshift_oauth=False

  • Run cluster.up()
  • Check the dashboard route - this should have tls set to edge in the openshift console.
  • The dashboard should work as expected and be secure

  2 - In the ClusterConfiguration set openshift_oauth=True

  • Run cluster.up()
  • Check the dashboard route - this should have tls set to reencrypt in the openshift console.
  • The dashboard should work as expected and be secure

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[tedhtchang]

Good Job /lgtm Tested both cases on ODH2.7 with 0_basic_ray.ipynb notebook and

cluster = Cluster(ClusterConfiguration(
    name='raytest',
    namespace='default',
    num_workers=1,
    min_cpus=1,
    max_cpus=1,
    min_memory=2,
    max_memory=2,
    num_gpus=0,
    image="quay.io/project-codeflare/ray:latest-py39-cu118",
    instascale=False,
    openshift_oauth=True, # and False
    head_cpus=1,
    head_memory=2
))

[Bobbins228]

/approve
Tested basic and Oauth routes working as expected Nice work Fiona!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Bobbins228]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment