odh configmap configuration to default template - Fixed tests #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I also changed the removal of raycluster tls objects so it is done by name rather than all at once Signed-off-by: Kevin <kpostlet@redhat.com>
Bobbins228
force-pushed
the
kevin-tests
branch
from
806acf3 to
c1a52a1
Compare
4 tasks
Contributor
Author
|
closing in favour of #465 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the failing unit tests on Kevin's PR
I also changed the removal of raycluster tls objects so it is done by name rather than all at once
Issue link
https://redhat-internal.slack.com/archives/C06C5MK3MT9/p1708358451702429
https://issues.redhat.com/browse/RHOAIENG-3325
What changes have been made
I added optional configmaps to the default ray cluster template that match those generated by odh. I also changed the disabling of tls so that it removes only specific entries from volumes and volumeMounts that way it doesn't delete the volumes created in this PR
Verification steps
attempt to run a script that talks to endpoint with custom ca-cert and make sure it works without error or warning.
I'm not completely sure of a good way to test this
Checks