Skip to content

Mount ODH custom CA ConfigMap to default template #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 22, 2024
Merged

Mount ODH custom CA ConfigMap to default template #465

merged 5 commits into from
Feb 22, 2024

Conversation

@KPostOffice
Copy link
Contributor

@KPostOffice KPostOffice commented Feb 20, 2024

Issue link

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@KPostOffice KPostOffice force-pushed the fix-list-removal branch 2 times, most recently from c4d238a to b45e7cf Compare February 20, 2024 17:13
@KPostOffice
Copy link
Contributor Author

KPostOffice commented Feb 20, 2024

Supercedes: #463

@Bobbins228 Bobbins228 mentioned this pull request Feb 21, 2024
Closed
4 tasks
VanillaSpoon
VanillaSpoon reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@VanillaSpoon VanillaSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran though guided demos with this, everything appears to be mounted correctly and the tests are passing :) lgtm

astefanutti
astefanutti approved these changes Feb 21, 2024
View reviewed changes
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 21, 2024
@astefanutti
Copy link
Contributor

astefanutti commented Feb 21, 2024

/lgtm

Bobbins228
Bobbins228 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Ran through basic and local interactive everything is mounted as it should be.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, Bobbins228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Bobbins228,astefanutti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobbins228 Bobbins228 removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
tedhtchang
tedhtchang reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@tedhtchang tedhtchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there instruction for the ODH users to generate the odh-trusted-ca-bundle configmap ? otherwise /lgtm

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 21, 2024
tedhtchang
tedhtchang reviewed Feb 21, 2024
View reviewed changes
@KPostOffice KPostOffice force-pushed the fix-list-removal branch 2 times, most recently from a5ddd60 to 232bb0a Compare February 22, 2024 00:45
KPostOffice and others added 4 commits February 21, 2024 19:46
@KPostOffice
odh configmap configuration to default template
f3fdc8d 
I also changed the removal of raycluster tls objects so it is done by
name rather than all at once

Signed-off-by: Kevin <kpostlet@redhat.com>
@Bobbins228 @KPostOffice
Altered tests so they pass
45b8cbb
@Bobbins228 @KPostOffice
Specificed mount paths and fixed unit tests
2b748ad
@KPostOffice
fix remove by name function to not be in place
00f6b59 
Signed-off-by: Kevin <kpostlet@redhat.com>
@astefanutti
Copy link
Contributor

astefanutti commented Feb 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8f89164 into project-codeflare:main Feb 22, 2024
@astefanutti
Copy link
Contributor

astefanutti commented Feb 28, 2024

/retitle Mount ODH custom CA ConfigMap to default template

@openshift-ci openshift-ci bot changed the title Fix list removal Mount ODH custom CA ConfigMap to default template Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristianZaccaria ChristianZaccaria Awaiting requested review from ChristianZaccaria

@Maxusmusti Maxusmusti Awaiting requested review from Maxusmusti

4 more reviewers

@tedhtchang tedhtchang tedhtchang left review comments

@VanillaSpoon VanillaSpoon VanillaSpoon left review comments

@astefanutti astefanutti astefanutti approved these changes

@Bobbins228 Bobbins228 Bobbins228 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@astefanutti astefanutti

@Bobbins228 Bobbins228

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KPostOffice @astefanutti @tedhtchang @VanillaSpoon @Bobbins228