Skip to content

Conversation

@ChristianZaccaria
Copy link
Contributor

Issue link

Issue: https://issues.redhat.com/browse/RHOAIENG-4471

What changes have been made

image

  • Warning when running pytest unit tests. This is due to having an unknown option in the pyproject.toml file, such as timeout.
  • Increase pretty_print coverage from 97% to 100%
    image

Verification steps

  1. pip install coverage - if required
  2. Run the SDK: pip install -e .
  3. coverage run -m --source=src pytest -v tests/unit_test.py
  4. No warnings should be in the output.
  5. Run coverage html
  6. The html link will show the full coverage report.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to run successfully.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through works as expected nice work!
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0c014f1 into project-codeflare:main Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants