Skip to content

Conversation

@pawelpaszki
Copy link
Contributor

Issue link

What changes have been made

fix: mnist test RHOAI 3.0

Verification steps

Login to RHOAI 3.0 cluster (with idp user same as in ods-ci) and run the test as follows:

python3.11 -m venv test
source test/bin/activate
poetry install --with test
poetry run pytest tests/e2e/mnist_raycluster_sdk_oauth_test.py -v -s --tb=short

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.34%. Comparing base (67df4f5) to head (360f94b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #934   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files          24       24           
  Lines        2068     2070    +2     
=======================================
+ Hits         1951     1953    +2     
  Misses        117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@kryanbeane kryanbeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there's that one redundant if statement but still approving. The rest looks goood

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@pawelpaszki
Copy link
Contributor Author

/override "e2e / kubernetes (pull_request)"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@pawelpaszki: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e / kubernetes (pull_request)

Only the following failed contexts/checkruns were expected:

  • add-approve-lgtm-label
  • kubernetes
  • tide
  • verify-0_basic_ray
  • verify-1_cluster_job_client
  • verify-2_basic_interactive
  • verify-3_widget_example
  • verify-local_interactive
  • verify-ray_job_client

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "e2e / kubernetes (pull_request)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pawelpaszki
Copy link
Contributor Author

/override kubernetes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@pawelpaszki: Overrode contexts on behalf of pawelpaszki: kubernetes

In response to this:

/override kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pawelpaszki pawelpaszki merged commit 21df064 into project-codeflare:main Nov 5, 2025
20 of 22 checks passed
@pawelpaszki pawelpaszki deleted the fix-mnist-test-3.0 branch November 5, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants