-
Notifications
You must be signed in to change notification settings - Fork 58
fix: mnist test RHOAI 3.0 #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mnist test RHOAI 3.0 #934
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #934 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 24 24
Lines 2068 2070 +2
=======================================
+ Hits 1951 1953 +2
Misses 117 117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7cad053 to
360f94b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: there's that one redundant if statement but still approving. The rest looks goood
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kryanbeane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override "e2e / kubernetes (pull_request)" |
|
@pawelpaszki: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override kubernetes |
|
@pawelpaszki: Overrode contexts on behalf of pawelpaszki: kubernetes In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issue link
What changes have been made
fix: mnist test RHOAI 3.0
Verification steps
Login to RHOAI 3.0 cluster (with idp user same as in ods-ci) and run the test as follows:
Checks