Skip to content

cluster-checker: warn when a single pod workload is using roce_gdr #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2024
Merged

cluster-checker: warn when a single pod workload is using roce_gdr #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions tools/cluster-checker/checker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ function reservation (pod) {
}

// check container resource requests against node_resources
function checkContainerResources(namespace, workload, container) {
function checkContainerResources(namespace, workload, workloadReplicas, container) {
// selectively merge limits into requests
const resources = {}
for (const k in container.resources?.requests ?? []) {
Expand Down Expand Up @@ -190,6 +190,11 @@ function checkContainerResources(namespace, workload, container) {
if (gpus > 0 && (mem > 0) && (mem/gpus > k8srp.memoryParser(nodeResources['memory'])/nodeResources['nvidia.com/gpu'])) {
console.log(`WARNING: workload "${namespace.metadata.name}/${workload.metadata.name}" has a container requesting ${resources['memory']} memory but only ${gpus} GPUs`)
}

// warn if other resource constraints are violated
if (gdr > 0 && workloadReplicas < 2) {
console.log(`WARNING: workload "${namespace.metadata.name}/${workload.metadata.name}" is a single pod workload that is requesting ${gdr} roce_gdr`)
}
}

// check user namespace
Expand Down Expand Up @@ -225,12 +230,16 @@ async function checkUserNamespace (client, namespace, queues) {
}

// report misconfigured resource requests
let replicas = 0
for (const podSet of workload.spec?.podSets) {
replicas += podSet.count ?? 0
}
for (const podSet of workload.spec?.podSets) {
for (const ic of podSet.template?.spec?.initContainers ?? []) {
checkContainerResources(namespace, workload, ic)
checkContainerResources(namespace, workload, replicas, ic)
}
for (const c of podSet.template?.spec?.containers ?? []) {
checkContainerResources(namespace, workload, c)
checkContainerResources(namespace, workload, replicas, c)
}
}
}
Expand Down