Set image create #441
Merged
Set image create #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just had the wrong logic so it was outputing the container rootfs to the filesystem instead of to the image store. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
set_image_create
branch
from
6cf2430 to
da30e53
Compare
Before this was just using whatever created time was set on the base image config which was incorrect. Example using the `docker buildx bake runc-jammy-container` command: Before: docker image ls | grep runc runc jammy 8d1d42e074f3 25 minutes ago 228MB After: docker image ls | grep runc runc jammy 03c24620c8fa 5 seconds ago 228MB **Note**: how the created time before was 25mins ago (b/c apparently the base jammy image was recently updated, I've seen this be 2 weeks) compared to after its 5 seconds ago. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
set_image_create
branch
from
da30e53 to
686d156
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- docker-bake.hcl: Language not supported
Comments skipped due to low confidence (1)
frontend/build.go:94
- Ensure that the new behavior of setting the image creation time is covered by tests.
cfg.Created = &now
DannyBrito
reviewed
Dec 5, 2024
DannyBrito
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set image config created time
Before this was just using whatever created time was set on the base
image config which was incorrect.
Example using the
docker buildx bake runc-jammy-containercommand:Before:
After:
Note: how the created time before was 25mins ago (b/c apparently the base
jammy image was recently updated, I've seen this be 2 weeks) compared to
after its 5 seconds ago.