add mirror for golang 1.25 #896
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to bump the Go version from 1.24 to 1.25 by updating the base image in the Dockerfile. However, the update is incomplete as it only modifies the Dockerfile while leaving numerous other Go version references throughout the codebase unchanged.
Key Changes
- Updated the base Go image from
golang:1.24togolang:1.25in the Dockerfile - Updated the image digest to match the new Go 1.25 image
MorrisLaw
approved these changes
Dec 10, 2025
willie-yao
force-pushed
the
golang-1.25
branch
2 times, most recently
from
05dc950 to
c320606
Compare
Signed-off-by: William Yao <william2000yao@gmail.com>
willie-yao
force-pushed
the
golang-1.25
branch
from
c320606 to
f62589b
Compare
MorrisLaw
approved these changes
Dec 10, 2025
Contributor
|
Did we mean to change this to something else? Or did we want both? What's the goal w/ the PR? @willie-yao |
Contributor
Author
|
@MorrisLaw It was to address this comment but I misunderstood some directions from Brian 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add mirror for golang 1.25
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: