frontend: fix handling no-cache filters #950
Merged
+54
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There are at least 2 bugs in the current implementation of IgnoreCache function:
bufio.NewReader.ReadString as stated in the docs:
If ReadString encounters an error before finding a delimiter, it returns the data read before the error and the error itself (often io.EOF).
This means when there is only a single filter specified, it will be returned together with io.EOF, meaning no cache ignoring will actually happen with existing code.
bufio.NewReader.ReadString as stated in the docs:
ReadString reads until the first occurrence of delim in the input, returning a string containing the data up to and including the delimiter.
As we register keys without a delimiter but compare them with one, ignoring cache will actually never work.
This patch fixes both issues by using strings.SplitSeq to split the filters.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Closes #949