Revert "test/testenv: run dial-stdio with Pdeathsig and process group"#981
Closed
Revert "test/testenv: run dial-stdio with Pdeathsig and process group"#981
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the earlier change that ran dial-stdio with Pdeathsig and a separate process group, restoring a more cross-platform-friendly implementation.
Changes:
- Removed
syscall.SysProcAttrusage (Setpgid,Pdeathsig) and the associatedruntime.LockOSThread()workaround. - Simplified process start/wait flow for the
docker buildx dial-stdiocommand. - Renamed the process completion channel used by the cleanup select.
This reverts commit 5fa6484. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
invidian
force-pushed
the
revert-980-fix-leaking-dial-stdio
branch
from
22d4cdc to
75972a8
Compare
cpuguy83
approved these changes
Mar 3, 2026
Collaborator
|
Handed in #982 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #980
I am actually still working on a better fix for that, I forgot to turn the original PR into a draft before merging, since it is not cross-platform compatible for example.