Skip to content

fix(services/account): removeFromUniqueAccount#48

Merged
antonstjernquist merged 2 commits intoproject-error:developfrom
qalle-git:develop
Sep 6, 2022
Merged

fix(services/account): removeFromUniqueAccount#48
antonstjernquist merged 2 commits intoproject-error:developfrom
qalle-git:develop

Conversation

@qalle-git
Copy link
Copy Markdown
Contributor

@qalle-git qalle-git commented Sep 5, 2022

Pull Request Description

  • Don't add to the sharedaccount if the user already is in it.
  • Actually remove the user from the shared account when removing.

Pull Request Checklist:

  • Have you followed the guidelines in our contributing document and Code of Conduct?
  • Have you checked to ensure there aren't other open for the same update/change?
  • Have you built and tested the resource in-game after the relevant change?

@qalle-git qalle-git mentioned this pull request Sep 5, 2022
Merged
3 tasks
antonstjernquist
antonstjernquist approved these changes Sep 6, 2022
View reviewed changes
Comment thread src/server/services/account/account.service.ts
@antonstjernquist antonstjernquist merged commit f40b836 into project-error:develop Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonstjernquist antonstjernquist antonstjernquist approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qalle-git @antonstjernquist