This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Added EdgeDevice finalizer to ensure EDSR removal #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dzon <jdzon@redhat.com>
jakub-dzon
requested review from
gabriel-farache and
ydayagi
and removed request for
arielireni and
rgolangh
gabriel-farache
approved these changes
Jun 7, 2022
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabriel-farache, jakub-dzon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
Maybe the ESDR should have the ownerReference of the edge device and 0 logic should be added here. IMHO. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
EdgeDevicefinalier to ensure that relatedEDSRis removed.This finalizer does not directly block device deregistration.
Signed-off-by: Jakub Dzon jdzon@redhat.com