Add the upgrade attributes to the edge device CRD #69
Conversation
bardielle
changed the title
bardielle
force-pushed
the
fleet_integration
branch
2 times, most recently
from
41b9604 to
bd9c79a
Compare
| type OsInformation struct { | ||
|
|
||
| //Automatically upgrade the OS image | ||
| AutomaticallyUpgrade bool `json:"automaticallyUpgrade,omitempty"` |
There was a problem hiding this comment.
Do we wish to have a broader policy than 'manual/auto' ?
There was a problem hiding this comment.
So perhaps this can be represented differently:
upgradePolicy: (any of automaic/scheduled)
automaic: true
scheduled: cron expression
Or in alternative way that will enable it.
There was a problem hiding this comment.
I will do it as part of the task: https://github.com/jakub-dzon/k4e-operator/pull/69#pullrequestreview-867575037
bardielle
force-pushed
the
fleet_integration
branch
7 times, most recently
from
9a742cb to
0cd5352
Compare
bardielle
changed the title
api/v1alpha1/edgedevice_types.go
Outdated
| CommitID string `json:"commitID,omitempty"` | ||
|
|
||
| //HostedImagesURL carries the URL of the hosted images web server | ||
| HostedImagesURL string `json:"hostedImagesURL,omitempty"` |
There was a problem hiding this comment.
Will you be changing that to reflect the fact that it points to os-tree commits rather than images?
There was a problem hiding this comment.
It points to the hosted Images service as it's mentioned in fleet management
In our case, RFE automation pipeline would be the hosted images service
There was a problem hiding this comment.
As discussed during demo, we don't download any images from there at that point (when device is running); only RFE commits, right? IMO something like HostedObjectsURL or similar would be more appropriate.
|
Please rebase. |
bardielle
force-pushed
the
fleet_integration
branch
from
0cd5352 to
e07c3b6
Compare
bardielle
force-pushed
the
fleet_integration
branch
from
e07c3b6 to
f1b9f49
Compare
bardielle
force-pushed
the
fleet_integration
branch
from
f1b9f49 to
4fbf9dc
Compare
4 participants
No description provided.