Fix smartpqi arcconf parsing for mixed SSD/HDD arrays with 4K block sizes#137
Fix smartpqi arcconf parsing for mixed SSD/HDD arrays with 4K block sizes#137raharper merged 1 commit intoproject-machine:mainfrom
Conversation
andaaron
commented
Feb 27, 2026
- Handle "4K Bytes" and other SI-suffixed block size tokens that caused strconv.Atoi failures on newer hardware.
- Split multiple logical devices within a single arcconf output chunk.
- Map new InterfaceType variants ("SATA SSD", "SAS 4K").
- Parse Channel and Protocol from physical device output.
- Fix GetDiskType returning HDD for the first non-matching drive.
raharper
left a comment
There was a problem hiding this comment.
Thanks for adding some additional support and with tests!
I left some minor items; I think mostly around the parseBlockSize; I'd like to simplify and make it clear we're looking at the Disk "geometry" or "sector size" or "native block"; rather than anything related to capacity of a disk.
Please take a look.
raharper
left a comment
There was a problem hiding this comment.
Thanks for updating the parseBlockSize. I'm +1 once squashed and CI passes.
…izes
1. Handle "4K Bytes" and other SI-suffixed block size tokens that caused
strconv.Atoi failures on newer hardware.
2. Split multiple logical devices within a single arcconf output chunk.
3. Map new InterfaceType variants ("SATA SSD", "SAS 4K").
4. Parse Channel and Protocol from physical device output.
5. Fix GetDiskType returning HDD for the first non-matching drive.
Signed-off-by: Andrei Aaron <andaaron@cisco.com>
|
@raharper, I have fixed the issue, please run CI again. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 49.40% 49.97% +0.56%
==========================================
Files 27 27
Lines 3633 3666 +33
==========================================
+ Hits 1795 1832 +37
+ Misses 1624 1621 -3
+ Partials 214 213 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|