Merged
Conversation
rnc
changed the title
akridl
approved these changes
Mar 24, 2026
Member
akridl
left a comment
akridl
left a comment
There was a problem hiding this comment.
I was checking all of my PNC-related repositories, and could not find the usage anywhere else other than reqour:
╰─❯ grep -RPo "^import org.jboss.pnc.api.dto.GAV;$"
reqour/adjuster/src/main/java/org/jboss/pnc/reqour/adjust/service/RootGavExtractor.java:import org.jboss.pnc.api.dto.GAV;
reqour/adjuster/src/test/java/org/jboss/pnc/reqour/adjust/service/RootGavExtractorTest.java:import org.jboss.pnc.api.dto.GAV;
(same for GA class), so should be fine to get rid of this, and start using from reqour the proper class, as already proposed in project-ncl/reqour#271
@rnc , once again, thank you a lot for this change! (and sorry for introducing this inaccuracy myself back then!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NCL-9564
This removes the GA/GAV added by @akridl for NCL-8828 in #241 - reqour can instead use project-ncl/pom-manipulation-ext#1112 This PR should not be merged until the PME PR is merged so not to break reqour.