Skip to content

Fetch tags regardless of fetch-depth#39

Merged
thescouser89 merged 1 commit intoproject-ncl:mainfrom
rnc:BR3
May 5, 2026
Merged

Fetch tags regardless of fetch-depth#39
thescouser89 merged 1 commit intoproject-ncl:mainfrom
rnc:BR3

Conversation

@rnc
Copy link
Copy Markdown
Contributor

@rnc rnc commented May 1, 2026

We need to fetch tags to correctly calculate the gh release tags

@rnc rnc requested a review from thescouser89 May 1, 2026 18:45
Copy link
Copy Markdown
Contributor

@thescouser89 thescouser89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but from actions/checkout#1471 , there might be a bug where fetch-tags setting is ignored if fetch-depth is set to 1.

@rnc
Copy link
Copy Markdown
Contributor Author

rnc commented May 5, 2026

Approved, but from actions/checkout#1471 , there might be a bug where fetch-tags setting is ignored if fetch-depth is set to 1.

Huh, good find. According to https://github.com/actions/checkout/releases/tag/v6.0.2 our current version is 6.0.2. Should we just try it and see before attempting workarounds?

@thescouser89
Copy link
Copy Markdown
Contributor

Sounds good! Let's see if that fixes it.

@thescouser89 thescouser89 merged commit 401ca54 into project-ncl:main May 5, 2026
2 checks passed
@rnc rnc deleted the BR3 branch May 6, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants