[NCL-9648] Add gradle build action#46
Conversation
| with: | ||
| java-version: "${{ inputs.java_version }}" | ||
| distribution: "temurin" | ||
| cache: gradle |
There was a problem hiding this comment.
This is missing matching configuration from the maven-snapshot i.e. configuring server-id, server-username etc. I am wondering if that is why I needed that workaround or deleting the settings file and generating a new one below below
There was a problem hiding this comment.
I think after some experimentation its due to the fact that the settings.xml always ends up being generated and the settings loader plugin I was using attempts to decrypt it annoyingly. I'm seeing if I can remove that plugin and use a custom implementation which would simplify the work here (See project-ncl/gradle-manipulator#538 )
| - name: Remove default GitHub Maven configuration | ||
| if: inputs.remove_default_maven_settings | ||
| shell: bash | ||
| run: rm -f ~/.m2/settings.xml |
There was a problem hiding this comment.
Note with project-ncl/gradle-manipulator#538 this can be removed
There was a problem hiding this comment.
removed; thank you for simplification
There was a problem hiding this comment.
do we also need
QUARKUS_CONTAINER_IMAGE_USERNAME: ${{ secrets.QUAY_DEVEL_USERNAME }}
QUARKUS_CONTAINER_IMAGE_PASSWORD: ${{ secrets.QUAY_DEVEL_PASSWORD }}
env vars (as in maven-snapshot)?
There was a problem hiding this comment.
I don't think we do ; currently nothing is being pushed to Quay.
|
due to referencing action in the reusable workflow, action has to be in separate PR |
|
This is looking good! Do we need #48 merged first? And the shellcheck fixed? |
patrikk0123
force-pushed
the
ncl9648-12
branch
2 times, most recently
from
eee8879 to
4f6ec20
Compare
|
@rnc Shellcheck fixed and build action merged and rebased onto it. Will add README changes. |
2 participants
No description provided.