Fix benches and add them to CI#3933
Merged
tiziano88 merged 1 commit intoproject-oak:mainfrom May 10, 2023
Merged
Conversation
tiziano88
force-pushed
the
tzn_fix_benches
branch
from
9520dd2 to
523ab00
Compare
jul-sh
approved these changes
May 10, 2023
| .unwrap(), | ||
| ))); | ||
|
|
||
| let oak_functions_linux_fd_bin_path = |
There was a problem hiding this comment.
given that this is now KVM version, should we rename this var?
Collaborator
Author
There was a problem hiding this comment.
Good catch, done.
|
|
||
| ./scripts/docker_pull | ||
| ./scripts/docker_run cargo nextest run --hide-progress-bar | ||
| ./scripts/docker_run cargo nextest run --all-targets --hide-progress-bar |
There was a problem hiding this comment.
I'm assuming this is what results in benches being run in CI? Seems suprising.
Collaborator
Author
There was a problem hiding this comment.
Yeah I was confused too, I always assumed --all-targets means it tries all the possible --targets, instead it's really so it also runs benches (with a single iteration, AFAICT) and examples, which is what we want. Added a comment.
tiziano88
force-pushed
the
tzn_fix_benches
branch
from
523ab00 to
135e6c3
Compare
tiziano88
force-pushed
the
tzn_fix_benches
branch
from
135e6c3 to
906a990
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is more room for improvement in sharing logic between benches, tests and xtask, but I'll leave that for a separate PR.
Ref #3931 #3738