Skip to content

Conversation

@projectorigin-renovate
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
sha3 dependencies minor 0.9 -> 0.10

Release Notes

RustCrypto/hashes (sha3)

v0.10.7

Compare Source

v0.10.6

Compare Source

v0.10.5

Compare Source

v0.10.4

Compare Source

v0.10.3

Compare Source

v0.10.2

Compare Source

v0.10.1

Compare Source

v0.10.0

Compare Source

v0.9.1

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@MartinSchmidt
Copy link
Member

@quackzar something you understand, the build error:

error[E0277]: the trait bound `CoreWrapper<Sha3_512Core>: curve25519_dalek_ng::digest::Update` is not satisfied
   --> src/scalar.rs:25:44
    |
25  |     let scalar = Scalar::hash_from_bytes::<Sha3_512>(bytes);
    |                                            ^^^^^^^^ the trait `curve25519_dalek_ng::digest::Update` is not implemented for `CoreWrapper<Sha3_512Core>`
    |
    = help: the following other types implement trait `curve25519_dalek_ng::digest::Update`:
              sha3::Keccak224
              sha3::Keccak256
              sha3::Keccak256Full
              sha3::Keccak384
              sha3::Keccak512
              sha3::Sha3_224
              sha3::Sha3_256
              sha3::Sha3_384
            and 3 others
    = note: required for `CoreWrapper<Sha3_512Core>` to implement `curve25519_dalek_ng::digest::Digest`
note: required by a bound in `Scalar::hash_from_bytes`
   --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/curve25519-dalek-ng-4.1.1/src/scalar.rs:588:18
    |
588 |         where D: Digest<OutputSize = U64> + Default
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Scalar::hash_from_bytes`

@projectorigin-renovate projectorigin-renovate bot force-pushed the renovate/sha3-0.x branch 2 times, most recently from 4b2f05c to cf6d656 Compare March 22, 2024 10:48
@quackzar
Copy link
Contributor

Seems like the dependency update broke a trait. Unsure why, but it seems like the (forked) library curve25519-dalek-ng is a bit out-of-date, compared to the original. Apparently the bulletproof library (the forked one we use) have also changed to use the original (see zkcrypto/bulletproofs#16).

Changes curve25519-dalek-ng to curve25519-dalek
and the bulletproof library to be the current version on git,
since the one on crates.io is out of date.
@projectorigin-renovate
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@sonarqubecloud
Copy link

@projectorigin-renovate projectorigin-renovate bot merged commit 967f0ee into main Apr 3, 2024
@projectorigin-renovate projectorigin-renovate bot deleted the renovate/sha3-0.x branch April 3, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants