Make ping count/delay configurable#23
Merged
matburt merged 6 commits intoproject-receptor:masterfrom Sep 17, 2019
Merged
Conversation
* Adds `float` type to allowed value types * Modifies `entrypoints.run_as_ping` to use new config options * Modifies controller.send_directive` to use a new param named `expected_responses`, which allows us to stop waiting for more responses after the set # is received (defaults to 1 response)
Member
|
I wonder if we should allow a way to make this basically indefinite. Sometimes, and especially in the case of |
Contributor
Author
|
If we did, I'd break the connect logic out of We also need better response handling to make sure we're not getting fragments, but that's a different future PR. |
matburt
reviewed
Sep 10, 2019
* Use sign_and_serialize for consistency and future expandability * Clean up entrypoint code
matburt
approved these changes
Sep 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make ping count/delay configurable
floattype to allowed value typesentrypoints.run_as_pingto use new config optionsto use a new param namedexpected_responses`, which allows us to stop waiting for more responses after the set # is received (defaults to 1 response)