Fixed tests - probably terribly#31
Merged
matburt merged 1 commit intoproject-receptor:masterfrom Oct 9, 2019
Merged
Conversation
matburt
reviewed
Oct 8, 2019
| peer_config = [] | ||
| for peer in peers: | ||
| peer_config.extend(['--peer', peer]) | ||
| base_config = ['--node-id', node_name, '--data-dir', '/tmp/receptor', type, '--listen-port', str(unused_tcp_port_factory())] |
Member
There was a problem hiding this comment.
This bit here implies that /tmp/receptor already exists, either we need to pre-create it or have the test runner create a tmp dir using mkdtemp?
Collaborator
Author
There was a problem hiding this comment.
Ahh yes - I can fix that if the rest of the implementation seems OK
Member
There was a problem hiding this comment.
Although... no self deprecating comments in commit messages ;)
matburt
approved these changes
Oct 9, 2019
Member
|
I do get some messages indicating we're probably not handling some tasks but I think that's unrelated to this and we'll need to rework some more of our core unit testing to fix them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a starting point to fixing the tests - it was helpful for me to understand a little more about how receptor is working internally, please advise on pieces I should modify.
All 5 tests now pass, but I'm sure there are some items wrong in this PR.