Fixed issue-137: Gray out icons of not yet implemented features #144
Conversation
kevinaboos
left a comment
There was a problem hiding this comment.
Thanks for the PR! There's lots of unrelated formatting changes, but aside from that, I don't think we actually want to make the RoomstList sidebar so narrow -- it makes it hard to read longer room names (e.g., something like Matrix Rust SDK Development or Office of the Matrix.org Foundation). The general solution for this is to make the divider horizontally movable, which Julian and I have discussed already and is in the works.
Graying out the not-yet-implemented UI elements is a good idea. If you can reduce the PR changeset to cover only that, I'm happy to merge it. Thanks!
|
Actually most of these issues were already fixed here #138, maybe the todo list in the issue wasn't up to date (should've updated/closed when the PR was merged), we agreed on that sidebar size as narrow enough after those fixes. Besides that, I also agree on graying-out the disabled items further, thanks for also including menu items and for the color naming 🙌🏽 |
kevinaboos
left a comment
There was a problem hiding this comment.
thanks, looks good now. Can you restore login.toml? After that, I can merge this in.
|
I have restored the |

Fixed : #137