Skip to content

Fixed issue-137: Gray out icons of not yet implemented features #144

Merged
kevinaboos merged 6 commits into
project-robius:mainfrom
ZhangHanDong:issue-137
Sep 12, 2024
Merged

Fixed issue-137: Gray out icons of not yet implemented features #144
kevinaboos merged 6 commits into
project-robius:mainfrom
ZhangHanDong:issue-137

Conversation

@ZhangHanDong
Copy link
Copy Markdown
Contributor

@ZhangHanDong ZhangHanDong commented Sep 10, 2024

Fixed : #137

  • Gray out icons of not yet implemented features

@ZhangHanDong
Copy link
Copy Markdown
Contributor Author

Screenshot 2024-09-10 at 19 58 57

@ZhangHanDong ZhangHanDong changed the title Fixed issue-137: Gray out icons of not yet implemented features Fixed issue-137: Gray out icons of not yet implemented features && Make rooms list sidebar narrower Sep 10, 2024
Copy link
Copy Markdown
Member

@kevinaboos kevinaboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There's lots of unrelated formatting changes, but aside from that, I don't think we actually want to make the RoomstList sidebar so narrow -- it makes it hard to read longer room names (e.g., something like Matrix Rust SDK Development or Office of the Matrix.org Foundation). The general solution for this is to make the divider horizontally movable, which Julian and I have discussed already and is in the works.

Graying out the not-yet-implemented UI elements is a good idea. If you can reduce the PR changeset to cover only that, I'm happy to merge it. Thanks!

Comment thread login.toml
Comment thread src/home/rooms_list.rs Outdated
Comment thread src/home/rooms_sidebar.rs Outdated
@yulnr
Copy link
Copy Markdown
Contributor

yulnr commented Sep 11, 2024

Actually most of these issues were already fixed here #138, maybe the todo list in the issue wasn't up to date (should've updated/closed when the PR was merged), we agreed on that sidebar size as narrow enough after those fixes.

Besides that, I also agree on graying-out the disabled items further, thanks for also including menu items and for the color naming 🙌🏽

@ZhangHanDong ZhangHanDong changed the title Fixed issue-137: Gray out icons of not yet implemented features && Make rooms list sidebar narrower Fixed issue-137: Gray out icons of not yet implemented features Sep 11, 2024
Copy link
Copy Markdown
Member

@kevinaboos kevinaboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good now. Can you restore login.toml? After that, I can merge this in.

@ZhangHanDong
Copy link
Copy Markdown
Contributor Author

I have restored the login.toml

Copy link
Copy Markdown
Member

@kevinaboos kevinaboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm!

@kevinaboos kevinaboos merged commit f08dfb2 into project-robius:main Sep 12, 2024
alanpoon pushed a commit to alanpoon/robrix that referenced this pull request May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minor UI fixes and improvements

3 participants