Add parameter to enable debug output for webhooks#205
Open
Nyholm wants to merge 5 commits intoproject-satisfy:mainfrom
Open
Add parameter to enable debug output for webhooks#205Nyholm wants to merge 5 commits intoproject-satisfy:mainfrom
Nyholm wants to merge 5 commits intoproject-satisfy:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I notice frequent 500 on my webhooks and I have a hard time figure out why. Of course, I should follow up this PR to add logs. But it seams like we dont want to use LoggerInterface in this repo. Not sure why but I will be happy to add some logs.
This PR introduces a
BuildContextthat is passed up to theAbstractWebhook. If debug is enabled, we will output a nice content to our HTTP Response.