squashfs: rearrange the way we pass ldlibs #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way downstream golang projects don't have to know to pass all this extra nonsense in their builds, they get it for "free". we do it in this strange way with static_build because newer versions of cryptsetup (in particular, the latest version, which we're building to statically link against) depend on json-c, which is not in a lot of repos (e.g. ubuntu 20.04). so in order to work around this, we only expose these flags when we actually need them, when doing a static build. Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this way downstream golang projects don't have to know to pass all this
extra nonsense in their builds, they get it for "free".
we do it in this strange way with static_build because newer versions of
cryptsetup (in particular, the latest version, which we're building to
statically link against) depend on json-c, which is not in a lot of repos
(e.g. ubuntu 20.04).
so in order to work around this, we only expose these flags when we
actually need them, when doing a static build.
Signed-off-by: Tycho Andersen tycho@tycho.pizza