Skip to content

Conversation

@smoser
Copy link
Contributor

@smoser smoser commented Nov 9, 2023

In a single stacker file that used a squashfs image twice or more, stacker would mount the layers the first time correctly. The image build would fail. The reason was that maybeKernelSquashMount did not detected why the mount failed (it was already mounted), but only that it did fail. So the code then attempted to extract the squashfs layer with unsquashfs and an error would occur like:

FATAL ERROR: dir_scan: failed to change permissions for directory
.../roots/sha256_52068a5d6c1...02caeb3a706cba3a/overlay,
because Read-only file system
Parallel unsquashfs: Using 32 processors
691 inodes (966 blocks) to write

The error only actually occurs if:

  • user is priveleged (can do a kernel mount)
  • stacker is building squash images (--layer-type=squashfs)
  • user does not have squashfuse in their path.

This is fixed more correctly upstream in 565b032.

An example stacker file that would recreate:

b1:
  build_only: true
  from:
    type: docker
    url: oci:my-ocidir:base:latest-squashfs
run: |
  echo "hello world" > f1

b2:
  from:
    type: docker
    url: oci:my-ocidir:base:latest-squashfs
  run: |
    echo "goodbye" > f2

The fix here is not great... effectively grepping the output of 'mount'
for 'is already mounted'. We set the LANG environment variable to C
to avoid failures due to a translations.

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

In a single stacker file that used a squashfs image twice or more,
stacker would mount the layers the first time correctly.
The image build would fail.  The reason was that maybeKernelSquashMount
did not detected *why* the mount failed (it was already mounted), but
only that it did fail.  So the code then attempted to extract the
squashfs layer with unsquashfs and an error would occur like:

   FATAL ERROR: dir_scan: failed to change permissions for directory
      .../roots/sha256_52068a5d6c1...02caeb3a706cba3a/overlay,
      because Read-only file system
      Parallel unsquashfs: Using 32 processors
      691 inodes (966 blocks) to write

The error only actually occurs if:
 * user is priveleged (can do a kernel mount)
 * stacker is building squash images (--layer-type=squashfs)
 * user does not have squashfuse in their path.

This is fixed more correctly upstream in 565b032.

An example stacker file that would recreate:

    b1:
      build_only: true
      from:
        type: docker
        url: oci:my-ocidir:base:latest-squashfs
    run: |
      echo "hello world" > f1

    b2:
      from:
        type: docker
        url: oci:my-ocidir:base:latest-squashfs
      run: |
        echo "goodbye" > f2

The fix here is not great... effectively grepping the output of 'mount'
for 'is already mounted'.   We set the LANG environment variable to C
to avoid failures due to a translations.

Signed-off-by: Scott Moser <smoser@brickies.net>
@smoser smoser force-pushed the fix/0.40.x/not-kernel-mount-again branch from bca97b8 to 9025e4c Compare November 9, 2023 20:56
@rchincha rchincha merged commit 5c91928 into project-stacker:rel-0.40.x Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants