fix: recognize kernel mount failure when target already mounted. #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a single stacker file that used a squashfs image twice or more, stacker would mount the layers the first time correctly. The image build would fail. The reason was that maybeKernelSquashMount did not detected why the mount failed (it was already mounted), but only that it did fail. So the code then attempted to extract the squashfs layer with unsquashfs and an error would occur like:
FATAL ERROR: dir_scan: failed to change permissions for directory
.../roots/sha256_52068a5d6c1...02caeb3a706cba3a/overlay,
because Read-only file system
Parallel unsquashfs: Using 32 processors
691 inodes (966 blocks) to write
The error only actually occurs if:
This is fixed more correctly upstream in 565b032.
An example stacker file that would recreate:
The fix here is not great... effectively grepping the output of 'mount'
for 'is already mounted'. We set the LANG environment variable to C
to avoid failures due to a translations.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.