test: drop references to docker:// images from test/ #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests were using
type: docker
url: docker://ubuntu:latest
Rather than using:
type: oci
url: oci:${UBUNTU_OCI}
Replacing those with the oci reference drops a test runtime
dependency we have on docker hub.
I've left the 'type' of docker in place to test a code path
that uses 'type: docker' to refer to 'oci:'.
Signed-off-by: Scott Moser <smoser@brickies.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
=======================================
Coverage 13.01% 13.01%
=======================================
Files 40 40
Lines 6003 6003
=======================================
Hits 781 781
Misses 5094 5094
Partials 128 128 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were using
type: docker
url: docker://ubuntu:latest
Rather than using:
type: oci
url: oci:${UBUNTU_OCI}
Replacing those with the oci reference drops a test runtime dependency we have on docker hub.
I've left the 'type' of docker in place to test a code path that uses 'type: docker' to refer to 'oci:'.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.