fix: Update 'import' deprecation warning with a date. #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raharper
requested changes
Dec 4, 2023
smoser
force-pushed
the
fix/formal-deprecation-import
branch
3 times, most recently
from
df405f7 to
2dd1369
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
===========================================
+ Coverage 13.02% 57.06% +44.04%
===========================================
Files 40 64 +24
Lines 6057 7519 +1462
===========================================
+ Hits 789 4291 +3502
+ Misses 5136 2485 -2651
- Partials 132 743 +611 ☔ View full report in Codecov by Sentry. |
Putting a date in the deprecation warning message allows users to plan migration more effectively. The date chosen allows for plenty of time for users to migrate existing stacker.yaml files. Signed-off-by: Scott Moser <smoser@brickies.net>
smoser
force-pushed
the
fix/formal-deprecation-import
branch
from
2dd1369 to
b60d77f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting a date in the deprecation warning message allows users to plan migration more effectively. The date chosen allows for plenty of time for users to migrate existing stacker.yaml files.
#571.