Add Vcs* labels#12
Conversation
|
👍 from me. (I might suggest if VcsType is omitted it would default to git ;) ) |
There was a problem hiding this comment.
Perhaps: "The type of version control used by the application packaged in this container, generally one of git, hg, svn, cvs, bzr"
There was a problem hiding this comment.
The important piece is that we have to also standardize the things that go into the label in this case otherwise it isn't super useful.
There was a problem hiding this comment.
I've just pushed a change that is a variation on @philips suggestion. I've reworded slightly to avoid ambiguity between the container source and the application within (I'm thinking of a situation where the application inside does something with VCS; perhaps a container of gitlab; or the distinction between the source for the app, and the source for the container of the app).
I re-ordered the suggested VCS types in order of 'recommendation' (demoting CVS). I agree that the contents of the label will have to be standardised to be useful; hopefully this won't be a big problem in practise (git == git, at least :). If anyone wants to add or use another VCS, they could always submit another PR.
Add VcsType, VcsURL and VcsRef labels, used to describe where the image source can be obtained from version control. Discussed in issue projectatomic#10.
|
LGTM |
4 participants
Add VcsType, VcsURL and VcsRef labels, used to describe where the image source can be obtained
from version control.
Discussed in issue #10.