Fix script with according to latest openshift doc

[praveenkumar]

Latest openshift have deprecated --credentials options for oadm and start using --service-account.

https://docs.openshift.org/latest/install_config/install/deploy_router.html

Note: This patch tested with OSE3.2 and origin-v1.1.6 and able to provision as expected.

[praveenkumar]

@hferentschik @kadel Please review.

[hferentschik]

Looking good by just looking at it. I still need to test it as part of openshift-vagrant. Any chance you ran the server-spec tests or whatever is in adb-tests?

[hferentschik]

+1 for adding || exit 1. Let's try to make these scripts behave better in error cases.

[LalatenduMohanty]

Same here.

[praveenkumar]

@hferentschik Tried smote test and below is result which looks as expected because provider is libvirt and it doesn't have eth0 IP as 10.0.2.15.

  Failures:

  1) Interface "eth0" should have ipv4 address "10.0.2.15"
     On host `default'
     Failure/Error: it { should have_ipv4_address("10.0.2.15") }
       expected #has_ipv4_address?("10.0.2.15") to return true, got false
       sudo -p 'Password: ' /bin/sh -c ip\ -4\ addr\ show\ eth0\ \|\ grep\ \'inet\ 10\\.0\\.2\\.15/\'

     # ./spec/default/smoke/system_spec.rb:12:in `block (2 levels) in <top (required)>'

Deprecation Warnings:

Using `should` from rspec-expectations' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` with `config.expect_with(:rspec) { |c| c.syntax = :should }` instead. Called from /home/work/vagrant/base_cdk/tests/spec/default/smoke/openshift_spec.rb:37:in `block (2 levels) in <top (required)>'.


If you need more of the backtrace for any of these deprecations to
identify where to make the necessary changes, you can configure
`config.raise_errors_for_deprecations!`, and it will turn the
deprecation warnings into errors, giving you the full backtrace.

1 deprecation warning total

Finished in 6.1 seconds (files took 3 seconds to load)
32 examples, 1 failure

Failed examples:

rspec ./spec/default/smoke/system_spec.rb:12 # Interface "eth0" should have ipv4 address "10.0.2.15"

/usr/bin/ruby -I/opt/rh/rh-ruby22/root/usr/local/share/gems/gems/rspec-core-3.4.3/lib:/opt/rh/rh-ruby22/root/usr/local/share/gems/gems/rspec-support-3.4.1/lib /opt/rh/rh-ruby22/root/usr/local/share/gems/gems/rspec-core-3.4.3/exe/rspec --pattern spec/default/smoke/\*_spec.rb failed

[LalatenduMohanty]

LGTM. Merging this