This repository was archived by the owner on Feb 7, 2023. It is now read-only.
roles: implement retries and remove version check#190
Merged
mike-nguyen merged 1 commit intoprojectatomic:masterfrom Jun 22, 2017
Merged
roles: implement retries and remove version check#190mike-nguyen merged 1 commit intoprojectatomic:masterfrom
mike-nguyen merged 1 commit intoprojectatomic:masterfrom
Conversation
We no longer need to check the version of the `atomic` command in order to determine how to list images with the command, since all the platforms we test against are at version 1.12+ of `atomic`. Additionally, I added a retry loop on the `atomic pull` in order to mitigate any failures due to network problems. This address a small sliver of projectatomic#156
mike-nguyen
reviewed
Jun 21, 2017
| register: apb | ||
| retries: 5 | ||
| delay: 60 | ||
| until: apb|success |
Collaborator
There was a problem hiding this comment.
I love the shortcut for the retries here!
Collaborator
|
LGTM |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer need to check the version of the
atomiccommand inorder to determine how to list images with the command, since all the
platforms we test against are at version 1.12+ of
atomic.Additionally, I added a retry loop on the
atomic pullin order tomitigate any failures due to network problems.
This address a small sliver of #156