This repository was archived by the owner on Feb 7, 2023. It is now read-only.
Add etcd system container test to I-S-T#196
Merged
miabbott merged 1 commit intoprojectatomic:masterfrom Jul 11, 2017
Merged
Conversation
etcd_sys_container_install role: This check-in is a simple system container test for the improved sanity test (IST) Because the IST is comprised of only roles (and cannot be mixed with tasks), the etcd_sys_container_install role was made specifically to validate the install and configuration of etcd for IST. improved sanity test: In the IST, the etcd system container is installed and configured pre-upgrade and checked post upgrade for its existence. Then it is removed and re-installed to test the system container installation on HEAD. On a cloud_image test, the installation, configuration, and uninstallation is only checked once in the post upgrade section. This was done to ensure we have some coverage on the upgrade scenario and when running the test on a cloud_image with no upgrade. command / shell role: I added these two simple roles because sometimes you just want to run a command and check the output when you are in a role block. The command role was used to quickly validate the etcd service is running.
Collaborator
Author
Collaborator
Author
|
bot, retest this please |
Collaborator
|
The changes look sane to me. The If the |
Collaborator
Author
|
bot, retest this please |
Collaborator
Author
|
@miabbott I re-ran this manually on centos/7/atomic and it passed. While running manually he centos/7/atomic image was complaining about gpg-signatures. If I re-added the remote --no-gpg-verify and deployed HEAD^, i was able to run the test. |
Collaborator
|
Yeah, something is up with the CentOS AH ostree. Thanks for the manual test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
etcd_sys_container_install role:
This check-in is a simple system container test for the improved sanity test (IST)
Because the IST is comprised of only roles (and cannot be mixed with tasks), the
etcd_sys_container_install role was made specifically to validate the install
and configuration of etcd for IST.
improved sanity test:
In the IST, the etcd system container is installed and configured pre-upgrade
and checked post upgrade for its existence. Then it is removed and re-installed
to test the system container installation on HEAD. On a cloud_image test, the
installation, configuration, and uninstallation is only checked once in the post
upgrade section. This was done to ensure we have some coverage on the upgrade
scenario and when running the test on a cloud_image with no upgrade.
command / shell role:
I added these two simple roles because sometimes you just want to run a command
and check the output when you are in a role block. The command role was used
to quickly validate the etcd service is running.