This repository was archived by the owner on Feb 7, 2023. It is now read-only.
Update Dockerfiles to use proper FROM field#202
Merged
mike-nguyen merged 1 commit intoprojectatomic:masterfrom Jul 14, 2017
Merged
Update Dockerfiles to use proper FROM field#202mike-nguyen merged 1 commit intoprojectatomic:masterfrom
mike-nguyen merged 1 commit intoprojectatomic:masterfrom
Conversation
The Dockerfiles we use in our tests had a myriad of FROM formats, so this cleans up the state of those. Now all the FROM lines have the following: - fully-qualified domain - explict tag (:latest or otherwise) Additionally, the CentOS and Fedora base images are changed to be pulled from the community registries instead of docker.io
Member
|
LGTM |
Collaborator
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dockerfiles we use in our tests had a myriad of FROM formats, so
this cleans up the state of those. Now all the FROM lines have the
following:
Additionally, the CentOS and Fedora base images are changed to be
pulled from the community registries instead of docker.io